Fix missing team member images in calendar event #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
Thank you @mritosa, that's it. I have refactored your code to use the new operationSignature pattern. This will progressively replace useFindXXXRecords props and enable easiest use of apolloCache |
charlesBochet
approved these changes
May 15, 2024
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
### Work Fixed issue: twentyhq#5308 ### Before Team member images are absent from Calendar events participant chips.  ### After <img width="383" alt="Screenshot 2024-05-14 at 10 53 24" src="https://github.com/twentyhq/twenty/assets/100703401/b65efe8a-64de-4214-a60a-ee87d235953a"> ### Fix explained Redefined recordGqlField to fech Person and WorkspaceMember --------- Co-authored-by: Charles Bochet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work
Fixed issue: #5308
Before
Team member images are absent from Calendar events participant chips.
After
Fix explained
Redefined recordGqlField to fech Person and WorkspaceMember