Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Team Member Images in Calendar Events #5308

Closed
Bonapara opened this issue May 6, 2024 · 5 comments
Closed

Missing Team Member Images in Calendar Events #5308

Bonapara opened this issue May 6, 2024 · 5 comments
Assignees
@mritosa
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Bonapara commented May 6, 2024

Current Behavior

Team member images are absent from Calendar events participant chips.

Current Behavior

Desired Behavior

Integrate display of team member profile pictures in Calendar events participant chips.
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels May 6, 2024
@Bonapara
Copy link
Member Author

Bonapara commented May 7, 2024

Sure, Thanks @emiliomarquez

@emiliomarquez emiliomarquez removed their assignment May 7, 2024
@mritosa
Copy link
Contributor

mritosa commented May 8, 2024

Hello, im new to contirbuting. I would like to fix this issue.

@Bonapara
Copy link
Member Author

Bonapara commented May 8, 2024

Sure thanks for contributing! @mritosa

@mritosa
Copy link
Contributor

mritosa commented May 9, 2024

Hi, i need some help with this problem. I found out that response of request is not good.
Screenshot 2024-05-09 at 17 50 20
The request should return the Person object, but it only returns its ID. Do you have any idea where is the problem?

@Bonapara
Copy link
Member Author

@mritosa, could you ask on Discord? I'm not the right person to help!

This was referenced May 14, 2024
Closed
Merged
charlesBochet added a commit that referenced this issue May 15, 2024
@mritosa @charlesBochet
Fix missing team member images in calendar event (#5414)
e9a7a8a 
### Work
Fixed issue: #5308 
### Before
Team member images are absent from Calendar events participant chips.

![Before](https://github.com/twentyhq/twenty/assets/100703401/bd3408ad-4a07-430e-ba23-83cd0775492a)
### After
<img width="383" alt="Screenshot 2024-05-14 at 10 53 24"
src="https://github.com/twentyhq/twenty/assets/100703401/b65efe8a-64de-4214-a60a-ee87d235953a">

### Fix explained
Redefined recordGqlField to fech Person and WorkspaceMember

---------

Co-authored-by: Charles Bochet <[email protected]>
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this issue Oct 6, 2024
@mritosa @charlesBochet
Fix missing team member images in calendar event (twentyhq#5414)
9bb7117 
### Work
Fixed issue: twentyhq#5308 
### Before
Team member images are absent from Calendar events participant chips.

![Before](https://github.com/twentyhq/twenty/assets/100703401/bd3408ad-4a07-430e-ba23-83cd0775492a)
### After
<img width="383" alt="Screenshot 2024-05-14 at 10 53 24"
src="https://github.com/twentyhq/twenty/assets/100703401/b65efe8a-64de-4214-a60a-ee87d235953a">

### Fix explained
Redefined recordGqlField to fech Person and WorkspaceMember

---------

Co-authored-by: Charles Bochet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mritosa mritosa

Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Bonapara @emiliomarquez @mritosa and others