-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oauth for chrome extension #4870
Merged
FelixMalfait
merged 19 commits into
twentyhq:main
from
AdityaPimpalkar:chrome-extension-oauth
Apr 24, 2024
Merged
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5f43262
oauth for chrome extension
AdityaPimpalkar a92a803
local storage check fix
AdityaPimpalkar e50e4aa
lint fix, type fix and store tokens
AdityaPimpalkar a7aae9c
delete graphql
AdityaPimpalkar e244267
apollo fix
AdityaPimpalkar 8c73ecf
gql fix and short bug fix
AdityaPimpalkar 7ffce32
remove login token
AdityaPimpalkar 3e6b57e
refactor
AdityaPimpalkar 4bad520
Merge branch 'main' into chrome-extension-oauth
AdityaPimpalkar 4b3165c
add redirectUrl to launchWebOauth
AdityaPimpalkar 070c6dd
chain operations and add callbacks
AdityaPimpalkar ec33389
clean the state from local storee
AdityaPimpalkar 78124dc
add server url input
AdityaPimpalkar 2008946
lint fix
AdityaPimpalkar 4ccf294
css fix
AdityaPimpalkar a784113
path fix
AdityaPimpalkar 4a26673
node_env, manifest fix and lint fix
AdityaPimpalkar e0433de
Merge branch 'main' into chrome-extension-oauth
AdityaPimpalkar d9b8a70
Update node-environment.interface.ts
FelixMalfait File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import { | ||
ExchangeAuthCodeInput, | ||
ExchangeAuthCodeResponse, | ||
Tokens, | ||
} from '~/db/types/auth.types'; | ||
import { EXCHANGE_AUTHORIZATION_CODE } from '~/graphql/auth/mutations'; | ||
import { isDefined } from '~/utils/isDefined'; | ||
import { callMutation } from '~/utils/requestDb'; | ||
|
||
export const exchangeAuthorizationCode = async ( | ||
exchangeAuthCodeInput: ExchangeAuthCodeInput, | ||
): Promise<Tokens | null> => { | ||
const data = await callMutation<ExchangeAuthCodeResponse>( | ||
EXCHANGE_AUTHORIZATION_CODE, | ||
exchangeAuthCodeInput, | ||
); | ||
if (isDefined(data?.exchangeAuthorizationCode)) | ||
return data.exchangeAuthorizationCode; | ||
else return null; | ||
}; | ||
|
||
// export const RenewToken = async (appToken: string): Promise<Tokens | null> => { | ||
// const data = await callQuery<Tokens>(RENEW_TOKEN, { appToken }); | ||
// if (isDefined(data)) return data; | ||
// else return null; | ||
// }; | ||
Comment on lines
+22
to
+26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think its best to implement this in a follow up PR |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot use
node:crypto
to create acodeVerifier
andcodeChallenge
since this project is outside of node scope, hence the different alternativecrypto-js