feat: oauth for chrome extension #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs/FIXMEs:
|
AdityaPimpalkar
commented
Apr 10, 2024
| @@ -1,4 +1,8 @@ | |||
| import Crypto from 'crypto-js'; | |||
There was a problem hiding this comment.
I cannot use node:crypto to create a codeVerifier and codeChallenge since this project is outside of node scope, hence the different alternative crypto-js
AdityaPimpalkar
commented
Apr 10, 2024
Comment on lines
+22
to
+26
| // export const RenewToken = async (appToken: string): Promise<Tokens | null> => { | ||
| // const data = await callQuery<Tokens>(RENEW_TOKEN, { appToken }); | ||
| // if (isDefined(data)) return data; | ||
| // else return null; | ||
| // }; |
There was a problem hiding this comment.
I think its best to implement this in a follow up PR
AdityaPimpalkar
commented
Apr 10, 2024
Comment on lines
33
to
35
| {isAuthenticating ? ( | ||
| <Loader /> | ||
| ) : ( |
There was a problem hiding this comment.
Added the loader in here because we don't need a separate loading page now
|
@AdityaPimpalkar could you add a PR description here too, it will help the review :) |
|
|
||
| host_permissions: ['https://www.linkedin.com/*'], | ||
| host_permissions: ['https://www.linkedin.com/*', 'http://localhost:3001/*'], |
There was a problem hiding this comment.
Only add Localhost in dev env
There was a problem hiding this comment.
Otherwise add twenty.com (app or api?)
FelixMalfait
approved these changes
Apr 24, 2024
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
Previously we had to create a separate API key to give access to chrome extension so we can make calls to the DB. This PR includes logic to initiate a oauth flow with PKCE method which redirects to the `Authorise` screen to give access to server tokens. Implemented in this PR- 1. make `redirectUrl` a non-nullable parameter 2. Add `NODE_ENV` to environment variable service 3. new env variable `CHROME_EXTENSION_REDIRECT_URL` on server side 4. strict checks for redirectUrl 5. try catch blocks on utils db query methods 6. refactor Apollo Client to handle `unauthorized` condition 7. input field to enter server url (for self-hosting) 8. state to show user if its already connected 9. show error if oauth flow is cancelled by user Follow up PR - Renew token logic --------- Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had to create a separate API key to give access to chrome extension so we can make calls to the DB. This PR includes logic to initiate a oauth flow with PKCE method which redirects to the
Authorisescreen to give access to server tokens.Implemented in this PR-
redirectUrla non-nullable parameterNODE_ENVto environment variable serviceCHROME_EXTENSION_REDIRECT_URLon server sideunauthorizedconditionFollow up PR -
Renew token logic