Dropdown Tick box #8649
Assignees
Comments
|
Hi, I would like to take on this issue, can you please assign it to me? Thank you! |
|
Hi I would like to contribute on this feature can you please provide me instructions to get started contributing in this repo. |
|
Hii, I would like to contribute on this issue, please assign me! |
|
Did you start working on this @Rohitk131 ? |
|
Not yet |
Closed
|
Technical input :
|
github-project-automation
bot
moved this from 🔖 Planned
to ✅ Done
in Product development ✅
lucasbordeau
pushed a commit
that referenced
this issue
Dec 24, 2024
Closes: #8647 Closes: #8649 **Changes & Why** 1. Added a Search Input to `SettingsDataModelFieldAddressForm` & `SettingsDataModelFieldCurrencyForm` as `Select` component already accepts it as a prop. 2. Gave a fixed width to the dropdown of both the above components to ensure it doesn't shrink on search for the menu items with low word count. 3. Added countries Flag to `SettingsDataModelFieldAddressForm`. 4. Replaced `MenuItem` with `MenuItemSelect` to get the desired highlighted background for the selected item with `IconCheck` to differentiate the current selected item. This is useful across all the select components throughout the app. 5. I realized that in some components we might not need IconCheck and only need a highlighted background for the selected item. For ex: `SettingsDataModelFieldBooleanForm` . Therefore, I created a prop `needIconCheck` with default as true so it doesn't break the existing `MenuItemSelect` and we can pass that prop as false wherever needed. [Screencast from 2024-12-21 12-08-08.webm](https://github.com/user-attachments/assets/4f8070a8-f339-4556-a137-bbbad58b171c)
samyakpiya
pushed a commit
to samyakpiya/twenty
that referenced
this issue
Dec 28, 2024
Closes: twentyhq#8647 Closes: twentyhq#8649 **Changes & Why** 1. Added a Search Input to `SettingsDataModelFieldAddressForm` & `SettingsDataModelFieldCurrencyForm` as `Select` component already accepts it as a prop. 2. Gave a fixed width to the dropdown of both the above components to ensure it doesn't shrink on search for the menu items with low word count. 3. Added countries Flag to `SettingsDataModelFieldAddressForm`. 4. Replaced `MenuItem` with `MenuItemSelect` to get the desired highlighted background for the selected item with `IconCheck` to differentiate the current selected item. This is useful across all the select components throughout the app. 5. I realized that in some components we might not need IconCheck and only need a highlighted background for the selected item. For ex: `SettingsDataModelFieldBooleanForm` . Therefore, I created a prop `needIconCheck` with default as true so it doesn't break the existing `MenuItemSelect` and we can pass that prop as false wherever needed. [Screencast from 2024-12-21 12-08-08.webm](https://github.com/user-attachments/assets/4f8070a8-f339-4556-a137-bbbad58b171c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We would like to have a Dropdown Tick box for selected option in field metadata select
Current behavior
When Selecting Currencies or Countries, you click on the dropdown. If you click again, there is no visual element showing that the row was clicked.
Example:
Expected behavior
Let's add a tickbox to show the selected item(s)
Technical inputs
Only frontend work here. Backend should remain untouched.
Related to #8647 (search ability)
As view with @Bonapara
The text was updated successfully, but these errors were encountered: