Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Form Select refacto #8751

Closed
guillim opened this issue Nov 26, 2024 · 1 comment · Fixed by #8875
Closed

Settings Form Select refacto #8751

guillim opened this issue Nov 26, 2024 · 1 comment · Fixed by #8875
Assignees
Labels
-PR: wip prio: med scope: front Issues that are affecting the frontend side only

Comments

@guillim
Copy link
Contributor

guillim commented Nov 26, 2024

Scope & Context

To handle better the way Select look and feel on Settings, we need to have the ability to choose which kind of select component we want. Currently, on the card forces the use of a styled "Select". But it does not meet the requirements for the Phones Select for instance.

Current behavior

Currently select have to look like this

Image

Expected behavior

We would like to have customisation so that select can look like this :

Image

Technical inputs

  • We should be able to choose which type of Select we want from the page packages/twenty-front/src/modules/settings/data-model/fields/forms/components/SettingsDataModelFieldSettingsFormCard.tsx. Using {children} sounds like an easy solution to me.
  • Let's dig into one of the children : SettingsDataModelFieldNumberSettingsFormCard > SettingsDataModelFieldNumberForm . We can see that SettingsOptionCardContentSelect is automatically a '@/ui/input/components/Select' component. It would be great to have the option to choose another type of component.

Linked to #8081 and to #8647 and to #8649

@guillim guillim added prio: med scope: front Issues that are affecting the frontend side only type: feature labels Nov 26, 2024
@guillim guillim self-assigned this Nov 26, 2024
@charlesBochet charlesBochet moved this from 🆕 New to 🔖 Planned in 🎯 Roadmap & Sprints Nov 26, 2024
@guillim guillim moved this from 🔖 Planned to 🏗 In Progress in 🎯 Roadmap & Sprints Dec 4, 2024
@guillim
Copy link
Contributor Author

guillim commented Dec 4, 2024

Starting to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-PR: wip prio: med scope: front Issues that are affecting the frontend side only
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants