Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should be allowed to override the defaultValue on standard fields #7104

Open
FelixMalfait opened this issue Sep 17, 2024 Discussed in #6933 · 6 comments
Open

We should be allowed to override the defaultValue on standard fields #7104

FelixMalfait opened this issue Sep 17, 2024 Discussed in #6933 · 6 comments
Assignees
Labels
prio: low scope: front Issues that are affecting the frontend side only size: short type: chore

Comments

@FelixMalfait
Copy link
Member

FelixMalfait commented Sep 17, 2024

Discussed in #6933

Originally posted by domenico-ruggiano September 8, 2024
Possibility to set a default currency other than USD dollars, for example € EUR.

I think we should let the user override the default value for standard fields
(we already let the edit values for enums)

CleanShot 2024-09-18 at 16 23 26

@Bonapara

This comment was marked as off-topic.

@Bonapara Bonapara removed the blocked: design needed This doesn't seem right label Sep 18, 2024
@FelixMalfait
Copy link
Member Author

@Bonapara the design has already been implemented for both. The issue is just that we are blocking the edition for standard fields (but it's possible to edit it on custom fields)

@FelixMalfait
Copy link
Member Author

Also valid for the options (stored in "settings"):
Screenshot 2024-09-25 at 11 02 23

Merging #6945 as it is but would be great to fix it in the context of this current issue - we'd like those options to be modifiable

@ehconitin
Copy link
Contributor

@FelixMalfait I am working on this!

@ehconitin ehconitin self-assigned this Oct 1, 2024
@ehconitin ehconitin moved this from 🆕 New to 🏗 In progress in Product development ✅ Oct 9, 2024
@FelixMalfait
Copy link
Member Author

@ad-elias will be working on this

Todo: check with px nx run twenty-server:command workspace:sync-metadata -f that it doesn't get overwritten

@ehconitin ehconitin removed their assignment Nov 12, 2024
@ehconitin
Copy link
Contributor

Thanks for taking this one @ad-elias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: low scope: front Issues that are affecting the frontend side only size: short type: chore
Projects
Status: 🏗 In Progress
Development

No branches or pull requests

4 participants