Allow standard field default value and settings editing (#7104) #8559
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enables editing of default values and settings for standard fields, removing previous restrictions that only allowed modifications to custom fields.
- Modified
buildUpdatableStandardFieldInputinfield-metadata.service.tsto includedefaultValueandsettingsfor standard fields - Removed
isCreatingFieldprop fromSettingsDataModelFieldSettingsFormCardto control field settings viaisCustomproperty - Removed edit mode restriction in
SettingsDataModelFieldBooleanFormto allow default value editing for existing boolean fields - Added support for
MULTI_SELECTfields alongsideSELECTfields in field metadata service - Removed
canPersistFieldMetadataItemUpdatefunction that previously restricted updates to custom fields only
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| actionButton={ | ||
| shouldDisplaySaveAndCancel && ( | ||
| <SaveAndCancelButtons | ||
| isSaveDisabled={!canSave} | ||
| isCancelDisabled={isSubmitting} | ||
| onCancel={() => navigate(`/settings/objects/${objectSlug}`)} | ||
| onSave={formConfig.handleSubmit(handleSave)} | ||
| /> | ||
| ) | ||
| <SaveAndCancelButtons | ||
| isSaveDisabled={!canSave} | ||
| isCancelDisabled={isSubmitting} | ||
| onCancel={() => navigate(`/settings/objects/${objectSlug}`)} | ||
| onSave={formConfig.handleSubmit(handleSave)} | ||
| /> | ||
| } |
There was a problem hiding this comment.
logic: Removing the restriction on standard field editing could have unintended consequences. Consider adding validation to prevent critical system fields from being modified.
| @@ -44,9 +42,6 @@ export const SettingsDataModelFieldBooleanForm = ({ | |||
| value={value} | |||
| onChange={onChange} | |||
| selectClassName={className} | |||
| // TODO: temporary fix - disabling edition because after editing the defaultValue, | |||
| // newly created records are not taking into account the updated defaultValue properly. | |||
There was a problem hiding this comment.
Could not replicate this issue so removed the comment
ad-elias
changed the title
|
Actually not ready to be merged yet, |
|
@ad-elias can you ping me when this is ready for review again? thanks :) |
|
@ijreilly Ready for review! |
|
Thanks @ad-elias for your contribution! |
No description provided.