Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side Panel compact header #6487

Closed
Bonapara opened this issue Aug 1, 2024 · 5 comments
Closed

Side Panel compact header #6487

Bonapara opened this issue Aug 1, 2024 · 5 comments
Assignees
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short

Comments

@Bonapara
Copy link
Member

Bonapara commented Aug 1, 2024

Current behavior

The Note side panel looks like the left column of the Record detail page

CleanShot 2024-08-01 at 11 14 53

Desired Behavior

We want to introduce a more compact header that looks like this for all side panel headers

image

Figma

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=36824-90523&t=7he5Wg1gGH5yGp53-11

@ehconitin
Copy link
Contributor

@Bonapara
Could this be dealt with issue #6489

@Bonapara
Copy link
Member Author

Bonapara commented Aug 1, 2024

I think it might be better to separate them so the PRs are easier to merge. Do you see another reason?

@ehconitin
Copy link
Contributor

Yea, its easy that way.
Assign this to me.
working on this also

@ehconitin
Copy link
Contributor

@Bonapara

Fixed in #6560

FelixMalfait pushed a commit that referenced this issue Aug 7, 2024
Fixes issue #6487 
Added a new prop, `isInRightDrawer` to both the `ShowPageSummaryCard`
and `ShowPageRightContainer` components. This prop allows for different
styles to be applied based on the specific needs of the drawer..

Rather than creating a new component, I opted to add this prop to avoid
code duplication. However, if you would prefer a separate component for
this functionality, I'm happy to make that adjustment—please just let me
know!

Also added `box-sizing: border-box` to `ShowPageSummaryCard` to make
sure it aligns with figma designs.



https://github.com/user-attachments/assets/38e8d85e-55d5-471e-884a-11c67467f56f
@ehconitin
Copy link
Contributor

@FelixMalfait Could you please close it when you get a chance? Thanks!

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in 🎯 Roadmap & Sprints Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for experienced contributor scope: front Issues that are affecting the frontend side only size: short
Projects
Archived in project
Development

No branches or pull requests

3 participants