Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Workspace Switcher with Breadcrumb by Adjusting Height #6375

Closed
Bonapara opened this issue Jul 23, 2024 · 3 comments
Closed

Align Workspace Switcher with Breadcrumb by Adjusting Height #6375

Bonapara opened this issue Jul 23, 2024 · 3 comments
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@Bonapara
Copy link
Member

Bonapara commented Jul 23, 2024 •
edited
Loading

Current behavior

The workspace switcher is not aligned with the breadcrumb.

CleanShot 2024-07-23 at 15 13 30

Desired Behavior

The container height should be 32px instead of 28px

CleanShot 2024-07-23 at 15 16 07

Also make sure to fix the Skeleton Loading alignment
@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels Jul 23, 2024
@ehconitin ehconitin mentioned this issue Jul 23, 2024
Merged
@ehconitin
Copy link
Contributor

Created PR6384.
Would you please look into it.

charlesBochet added a commit that referenced this issue Jul 25, 2024
@ehconitin @charlesBochet
Align Workspace Switcher with Breadcrumb by Adjusting Height (#6384)
9618639 
@Bonapara 
Issue #6375 

This change makes sure the container height is 32px instead of 28px.
should the container inside it should also be 32px, please refer video
below for context


https://github.com/user-attachments/assets/fe97f0de-e1fd-4fda-a9a7-e9585469c530


Also skeleton height is 20px (refer video below), the black component in
the video is the skeleton for this particular component.
What should be skeletons height?


https://github.com/user-attachments/assets/0956c8d9-8e4e-4c20-bb71-7fb1e2cba4fd

---------

Co-authored-by: Charles Bochet <[email protected]>
@soumyo123-prog
Copy link

Hi @Bonapara , is this issue still open, if so, I would like to work on it.

@charlesBochet
Copy link
Member

It seems to be solved, closing the issue :)

@soumyo123-prog feel free to take any other good first issue on the project!

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in 🎯 Roadmap & Sprints Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
🎯 Roadmap & Sprints
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@charlesBochet @Bonapara @soumyo123-prog @ehconitin