Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timebox] Use Nx affected feature in CI #5097

Closed
thaisguigon opened this issue Apr 22, 2024 · 0 comments · Fixed by #5110
Closed

[Timebox] Use Nx affected feature in CI #5097

thaisguigon opened this issue Apr 22, 2024 · 0 comments · Fixed by #5110
Assignees

Comments

@thaisguigon
Copy link
Contributor

No description provided.

@thaisguigon thaisguigon self-assigned this Apr 22, 2024
@thaisguigon thaisguigon moved this from 🆕 New to 🏗 In progress in Product development ✅ Apr 22, 2024
@thaisguigon thaisguigon changed the title Use Nx affected feature in CI [Timebox] Use Nx affected feature in CI Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 22, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 23, 2024
thaisguigon added a commit that referenced this issue Apr 24, 2024
@thaisguigon thaisguigon moved this from 🏗 In progress to 👀 In review in Product development ✅ Apr 24, 2024
thaisguigon added a commit that referenced this issue Apr 25, 2024
charlesBochet pushed a commit that referenced this issue Apr 30, 2024
Closes #5097

- Uses "nx affected" to detect what projects need to be checked in the
current PR (for now, `ci-front` and `ci-server` workflows only).
- Caches results of certain tasks (`lint`, `typecheck`, `test`,
`storybook:build`) when a PR pipeline runs. The next runs of the same
PR's pipeline will then be able to reuse the PR's task cache to execute
tasks faster.
- Caches Yarn's cache folder to install dependencies faster in CI jobs.
- Rewrites the node modules cache/install steps as a custom, reusable
Github action.
- Distributes `ci-front` jobs with a "matrix" strategy.
- Sets common tasks config at the root `nx.json`. For instance, to
activate the `typecheck` task in a project, add `typecheck: {}` to its
`project.json` and it'll use the default config set in `nx.json` for the
`typecheck` task. Options can be overridden in each individual
`project.json` if needed.
- Adds "scope" tags to some projects: `scope:frontend`, `scope:backend`,
`scope:shared`. An eslint rule ensures that `scope:frontend` only
depends on `scope:frontent` or `scope:shared` projects, same for
`scope:backend`. These tags are used by `nx affected` to filter projects
by scope and generates different task cache keys according to the
requested scope.
- Enables checks for twenty-emails in the `ci-server` workflow.
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Product development ✅ Apr 30, 2024
arnavsaxena17 pushed a commit to arnavsaxena17/twenty that referenced this issue Oct 6, 2024
Closes twentyhq#5097

- Uses "nx affected" to detect what projects need to be checked in the
current PR (for now, `ci-front` and `ci-server` workflows only).
- Caches results of certain tasks (`lint`, `typecheck`, `test`,
`storybook:build`) when a PR pipeline runs. The next runs of the same
PR's pipeline will then be able to reuse the PR's task cache to execute
tasks faster.
- Caches Yarn's cache folder to install dependencies faster in CI jobs.
- Rewrites the node modules cache/install steps as a custom, reusable
Github action.
- Distributes `ci-front` jobs with a "matrix" strategy.
- Sets common tasks config at the root `nx.json`. For instance, to
activate the `typecheck` task in a project, add `typecheck: {}` to its
`project.json` and it'll use the default config set in `nx.json` for the
`typecheck` task. Options can be overridden in each individual
`project.json` if needed.
- Adds "scope" tags to some projects: `scope:frontend`, `scope:backend`,
`scope:shared`. An eslint rule ensures that `scope:frontend` only
depends on `scope:frontent` or `scope:shared` projects, same for
`scope:backend`. These tags are used by `nx affected` to filter projects
by scope and generates different task cache keys according to the
requested scope.
- Enables checks for twenty-emails in the `ci-server` workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants
@thaisguigon and others