chore: use Nx affected tasks in CI

Closes #5097
twentyhq · Apr 23, 2024 · f85d641 · f85d641
1 parent fa4670b
commit f85d641
Show file tree

Hide file tree

Showing 13 changed files with 109 additions and 167 deletions.
diff --git a/.github/workflows/actions/nx-affected/action.yaml b/.github/workflows/actions/nx-affected/action.yaml
@@ -0,0 +1,30 @@
+name: Nx Affected CI
+on:
+  workflow_call:
+    inputs:
+      parallel:
+        required: false
+        types: [number]
+      tag:
+        required: false
+        types: [string]
+      target:
+        required: true
+        types: [string]
+
+jobs:
+  affected:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Nx Affected CI / Install Dependencies
+        uses: ./.github/workflows/actions/yarn-install
+      - uses: actions/checkout@v4
+        with:
+          # Fetch last 100 branches and commits so that Nx affected has a base to compare against.
+          fetch-depth: 100
+      - name: Nx Affected CI / Get last successful commit
+        id: setSHAs
+        uses: nrwl/nx-set-shas@v4
+      - name: Run affected command
+        run: npx nx affected --nxBail --configuration=ci -t ${{ inputs.target }} --parallel=${{ inputs.parallel }} --exclude='*,!tag:${{ inputs.tag }}'
diff --git a/.github/workflows/actions/yarn-install/action.yaml b/.github/workflows/actions/yarn-install/action.yaml
@@ -0,0 +1,16 @@
+name: Yarn Install
+on:
+  workflow_call:
+
+jobs:
+  affected:
+    runs-on: ci-8-cores
+    steps:
+      - uses: actions/checkout@v4
+      - name: Yarn Install / Setup Node.js and get cached dependencies
+        uses: actions/setup-node@v3
+        with:
+          node-version: "18"
+          cache: yarn
+      - name: Yarn Install / Install Dependencies
+        run: yarn --immutable
diff --git a/.github/workflows/ci-chromatic.yaml b/.github/workflows/ci-chromatic.yaml
@@ -27,17 +27,18 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - name: Setup Node.js
+      - name: Setup Node.js and get cached dependencies
         uses: actions/setup-node@v3
         with:
           node-version: "18"
+          cache: yarn
       - name: Front / Write .env
         run: |
           cd packages/twenty-front
           touch .env
           echo "REACT_APP_SERVER_BASE_URL: $REACT_APP_SERVER_BASE_URL" >> .env
       - name: Front / Install Dependencies
-        run: yarn
+        run: yarn --immutable
       - name: Publish to Chromatic
         run: |
           cd packages/twenty-front

diff --git a/.github/workflows/ci-chrome-extension.yaml b/.github/workflows/ci-chrome-extension.yaml
@@ -15,33 +15,7 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  chrome-extension-yarn-install:
-    runs-on: ci-8-cores
-    env:
-      VITE_SERVER_BASE_URL: http://localhost:3000
-      VITE_FRONT_BASE_URL: http://localhost:3001
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: "18"
-      - name: Cache chrome extension node modules
-        uses: actions/cache@v3
-        with:
-          path: packages/twenty-chrome-extension/node_modules
-          key: chrome-extension-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: chrome-extension-node_modules-
-      - name: Cache root node modules
-        uses: actions/cache@v3
-        with:
-          path: node_modules
-          key: root-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: root-node_modules-
-      - name: Chrome Extension / Install Dependencies
-        run: yarn
   chrome-extension-build:
-    needs: chrome-extension-yarn-install
     runs-on: ubuntu-latest
     env:
       VITE_SERVER_BASE_URL: http://localhost:3000
@@ -52,21 +26,12 @@ jobs:
         with:
             access_token: ${{ github.token }}
       - uses: actions/checkout@v4
-      - name: Setup Node.js
+      - name: Setup Node.js and get cached dependencies
         uses: actions/setup-node@v3
         with:
           node-version: "18"
-      - name: Cache chrome extension node modules
-        uses: actions/cache@v3
-        with:
-          path: packages/twenty-chrome-extension/node_modules
-          key: chrome-extension-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: chrome-extension-node_modules-
-      - name: Cache root node modules
-        uses: actions/cache@v3
-        with:
-          path: node_modules
-          key: root-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: root-node_modules-
+          cache: yarn
+      - name: Chome Extension / Install Dependencies
+        run: yarn --immutable
       - name: Chrome Extension / Run build
         run: npx nx build twenty-chrome-extension
diff --git a/.github/workflows/ci-docs.yaml b/.github/workflows/ci-docs.yaml
@@ -21,12 +21,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Setup Node.js
+      - name: Setup Node.js and get cached dependencies
         uses: actions/setup-node@v3
         with:
           node-version: "18"
+          cache: yarn
       - name: Docs / Install Dependencies
-        run: yarn
+        run: yarn --immutable
       - name: Docs / Build Documentation
         run: npx nx build twenty-docs
   vale:

diff --git a/.github/workflows/ci-front.yaml b/.github/workflows/ci-front.yaml
@@ -17,167 +17,78 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  front-yarn-install:
-    runs-on: ci-8-cores
-    env:
-      REACT_APP_SERVER_BASE_URL: http://localhost:3000
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: "18"
-      - name: Cache front node modules
-        uses: actions/cache@v3
-        with:
-          path: packages/twenty-front/node_modules
-          key: front-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: front-node_modules-
-      - name: Cache root node modules
-        uses: actions/cache@v3
-        with:
-          path: node_modules
-          key: root-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: root-node_modules-
-      - name: Front / Install Dependencies
-        run: yarn
   front-pages-sb-test:
-    needs: front-yarn-install
     runs-on: ci-8-cores
     env:
       REACT_APP_SERVER_BASE_URL: http://localhost:3000
+      STORYBOOK_SCOPE: pages
     steps:
       - name: Cancel Previous Runs
         uses: styfle/[email protected]
         with:
-            access_token: ${{ github.token }}
+          access_token: ${{ github.token }}
       - uses: actions/checkout@v4
-      - name: Setup Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: "18"
-      - name: Front / Write .env
-        run: |
-          cd packages/twenty-front
-          cp .env.example .env
-      - name: Cache front node modules
-        uses: actions/cache@v3
-        with:
-          path: packages/twenty-front/node_modules
-          key: front-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: front-node_modules-
-      - name: Cache root node modules
-        uses: actions/cache@v3
-        with:
-          path: node_modules
-          key: root-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: root-node_modules-
+      - name: Install dependencies
+        uses: ./.github/workflows/yarn-install.yaml
       - name: Install Playwright
         run: cd packages/twenty-front && npx playwright install
+      - name: Front / Write .env
+        run: npx nx reset:env twenty-front
       - name: Run storybook tests
         run: |
           npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
-            "STORYBOOK_SCOPE=pages npx nx run twenty-front:storybook:static:ci" \
-            "npx wait-on tcp:6006 && STORYBOOK_SCOPE=pages npx nx run twenty-front:storybook:test"
+            "npx nx run twenty-front:storybook:static:ci" \
+            "npx wait-on tcp:6006 && npx nx run twenty-front:storybook:test"
   front-modules-sb-test:
-    needs: front-yarn-install
     runs-on: ci-4-cores
     env:
       REACT_APP_SERVER_BASE_URL: http://localhost:3000
+      STORYBOOK_SCOPE: modules
     steps:
       - name: Cancel Previous Runs
         uses: styfle/[email protected]
         with:
             access_token: ${{ github.token }}
       - uses: actions/checkout@v4
-      - name: Setup Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: "18"
-      - name: Front / Write .env
-        run: |
-          cd packages/twenty-front
-          cp .env.example .env
-      - name: Cache front node modules
-        uses: actions/cache@v3
-        with:
-          path: packages/twenty-front/node_modules
-          key: front-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: front-node_modules-
-      - name: Cache root node modules
-        uses: actions/cache@v3
-        with:
-          path: node_modules
-          key: root-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: root-node_modules-
+      - name: Install dependencies
+        uses: ./.github/workflows/actions/yarn-install
       - name: Install Playwright
         run: cd packages/twenty-front && npx playwright install
+      - name: Front / Write .env
+        run: npx nx reset:env twenty-front
       - name: Run storybook tests
         run: |
           npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
-            "STORYBOOK_SCOPE=modules npx nx run twenty-front:storybook:static:ci" \
-            "npx wait-on tcp:6006 && STORYBOOK_SCOPE=modules npx nx run twenty-front:storybook:test"
+            "npx nx run twenty-front:storybook:static:ci" \
+            "npx wait-on tcp:6006 && npx nx run twenty-front:storybook:test"
   front-lint-tsc:
-    needs: front-yarn-install
     runs-on: ubuntu-latest
     env:
       REACT_APP_SERVER_BASE_URL: http://localhost:3000
     steps:
       - name: Cancel Previous Runs
         uses: styfle/[email protected]
         with:
-            access_token: ${{ github.token }}
+          access_token: ${{ github.token }}
       - uses: actions/checkout@v4
-      - name: Setup Node.js
-        uses: actions/setup-node@v3
+      - name: Front / Run linter & typecheck
+        uses: ./.github/workflows/actions/nx-affected
         with:
-          node-version: "18"
-      - name: Cache front node modules
-        uses: actions/cache@v3
-        with:
-          path: packages/twenty-front/node_modules
-          key: front-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: front-node_modules-
-      - name: Cache root node modules
-        uses: actions/cache@v3
-        with:
-          path: node_modules
-          key: root-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: root-node_modules-
-      - name: UI / Run linter
-        run: npx nx lint twenty-ui
-      - name: UI / Run Typescript Check
-        run: npx nx run twenty-ui:typecheck:ci
-      - name: Front / Run linter
-        run: npx nx run twenty-front:lint:ci
-      - name: Front / Run Typescript Check
-        run: npx nx run twenty-front:typecheck:ci
+          tag: scope:frontend
+          target: lint typecheck
   front-jest:
-    needs: front-yarn-install
     runs-on: ubuntu-latest
     env:
       REACT_APP_SERVER_BASE_URL: http://localhost:3000
     steps:
       - name: Cancel Previous Runs
         uses: styfle/[email protected]
         with:
-            access_token: ${{ github.token }}
+          access_token: ${{ github.token }}
       - uses: actions/checkout@v4
-      - name: Setup Node.js
-        uses: actions/setup-node@v3
-        with:
-          node-version: "18"
-      - name: Cache front node modules
-        uses: actions/cache@v3
-        with:
-          path: packages/twenty-front/node_modules
-          key: front-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: front-node_modules-
-      - name: Cache root node modules
-        uses: actions/cache@v3
-        with:
-          path: node_modules
-          key: root-node_modules-${{hashFiles('yarn.lock')}}
-          restore-keys: root-node_modules-
       - name: Front / Run jest
-        run: npx nx test twenty-front --configuration=ci
+        uses: ./.github/workflows/actions/nx-affected
+        with:
+          parallel: 1
+          tag: scope:frontend
+          target: test
diff --git a/.github/workflows/ci-server.yaml b/.github/workflows/ci-server.yaml
@@ -29,12 +29,13 @@ jobs:
           - 5432:5432
     steps:
       - uses: actions/checkout@v4
-      - name: Setup Node.js
+      - name: Setup Node.js and get cached dependencies
         uses: actions/setup-node@v3
         with:
           node-version: "18"
+          cache: yarn
       - name: Server / Install Dependencies
-        run: yarn
+        run: yarn --immutable
       - name: Server / Run linter
         run: npx nx lint twenty-server
       - name: Server / Run jest tests

diff --git a/.github/workflows/ci-utils.yaml b/.github/workflows/ci-utils.yaml
@@ -21,12 +21,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Setup Node.js
+      - name: Setup Node.js and get cached dependencies
         uses: actions/setup-node@v3
         with:
           node-version: "18"
+          cache: yarn
       - name: Utils / Install Dependencies
-        run: yarn
+        run: yarn --immutable
       - name: Utils / Run Danger.js
         run: cd packages/twenty-utils && npx nx danger:ci
         env:

diff --git a/.github/workflows/ci-website.yaml b/.github/workflows/ci-website.yaml
@@ -19,11 +19,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - name: Setup Node.js
+      - name: Setup Node.js and get cached dependencies
         uses: actions/setup-node@v3
         with:
           node-version: "18"
+          cache: yarn
       - name: Website / Install Dependencies
-        run: yarn
+        run: yarn --immutable
       - name: Website / Build Website
         run: npx nx build twenty-website
diff --git a/nx.json b/nx.json
@@ -1,4 +1,8 @@
 {
+  "namedInputs": {
+    "default": ["{projectRoot}/**/*", "sharedGlobals"],
+    "sharedGlobals": ["{workspaceRoot}/.github/workflows/ci-front.yaml"]
+  },
   "targetDefaults": {
     "build": {
       "cache": true,