Fixes #7220: Remove primary banner icon when only one value present

twentyhq · Sep 26, 2024 · e19d8bb · e19d8bb
1 parent 7c90e71
commit e19d8bb
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/...t/src/modules/object-record/record-field/meta-types/input/components/EmailsFieldInput.tsx b/...t/src/modules/object-record/record-field/meta-types/input/components/EmailsFieldInput.tsx
@@ -29,6 +29,8 @@ export const EmailsFieldInput = ({ onCancel }: EmailsFieldInputProps) => {
     });
   };
 
+  const isPrimaryEmail = (index: number) => index === 0 && emails?.length > 1;
+
   return (
     <MultiItemFieldInput
       items={emails}
@@ -46,7 +48,7 @@ export const EmailsFieldInput = ({ onCancel }: EmailsFieldInputProps) => {
         <EmailsFieldMenuItem
           key={index}
           dropdownId={`${hotkeyScope}-emails-${index}`}
-          isPrimary={index === 0}
+          isPrimary={isPrimaryEmail(index)}
           email={email}
           onEdit={handleEdit}
           onSetAsPrimary={handleSetPrimary}

diff --git a/...nt/src/modules/object-record/record-field/meta-types/input/components/LinksFieldInput.tsx b/...nt/src/modules/object-record/record-field/meta-types/input/components/LinksFieldInput.tsx
@@ -42,6 +42,8 @@ export const LinksFieldInput = ({ onCancel }: LinksFieldInputProps) => {
     });
   };
 
+  const isPrimaryLink = (index: number) => index === 0 && links?.length > 1;
+
   return (
     <MultiItemFieldInput
       items={links}
@@ -61,7 +63,7 @@ export const LinksFieldInput = ({ onCancel }: LinksFieldInputProps) => {
         <LinksFieldMenuItem
           key={index}
           dropdownId={`${hotkeyScope}-links-${index}`}
-          isPrimary={index === 0}
+          isPrimary={isPrimaryLink(index)}
           label={link.label}
           onEdit={handleEdit}
           onSetAsPrimary={handleSetPrimary}

diff --git a/...t/src/modules/object-record/record-field/meta-types/input/components/PhonesFieldInput.tsx b/...t/src/modules/object-record/record-field/meta-types/input/components/PhonesFieldInput.tsx
@@ -78,6 +78,8 @@ export const PhonesFieldInput = ({ onCancel }: PhonesFieldInputProps) => {
     });
   };
 
+  const isPrimaryPhone = (index: number) => index === 0 && phones?.length > 1;
+
   return (
     <MultiItemFieldInput
       items={phones}
@@ -108,7 +110,7 @@ export const PhonesFieldInput = ({ onCancel }: PhonesFieldInputProps) => {
         <PhonesFieldMenuItem
           key={index}
           dropdownId={`${hotkeyScope}-phones-${index}`}
-          isPrimary={index === 0}
+          isPrimary={isPrimaryPhone(index)}
           phone={phone}
           onEdit={handleEdit}
           onSetAsPrimary={handleSetPrimary}