-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Primary Banner Icon When Only One Value Present #7220
Comments
i am working on this, i managed to fix it for the emails and domains but i cant see the option to add phone numbers |
@syeddhasnainn The phone numbers issue is -> #6260 |
Sorry I started working on this and did not check to see that someone else had already said they wanted to work on it. This is my first contribution so I was just wondering if it was still okay to submit the PR? |
Thanks @KeeratKK, yes as it's a very small fix. @syeddhasnainn do you want to pick another Good First Issue? |
Sure |
…resent (twentyhq#7275) ## Changes - Added a check to make sure that we only indicate an entry is primary if there is more than one value. - The banner icon now only displays when there are either **2 or more emails, phone numbers, or domains.** ## Emails ![image](https://github.com/user-attachments/assets/54832aaf-a319-4b70-87bf-3621e05f1637) ![image](https://github.com/user-attachments/assets/44bb8909-9f34-426d-8942-2bb7974e9113) ## Phones ![image](https://github.com/user-attachments/assets/85ca4c36-c148-4d86-89d6-1c02a960f2f4) ![image](https://github.com/user-attachments/assets/f11b5c2e-4376-4bf6-8560-e4c956f2c2e5) ## Domains ![image](https://github.com/user-attachments/assets/ce324714-6bd7-45ac-9a2f-8a2671d080a0) ![image](https://github.com/user-attachments/assets/153883a3-782f-424b-abc4-d882ec969bc2) ## Notes This is my first time contributing so I am open to any feedback. Co-authored-by: Keerat Kohli <[email protected]>
Current Behavior
The first
email, phone, or domain
field has a banner icon to indicate it's the default/primary value.Desired Behavior
When there is only one value, we don't need to indicate it's the primary value or display the banner icon, as it is unnecessary and confusing for the three-dot icon menu.
The text was updated successfully, but these errors were encountered: