Conversation
Matches the convention already used elsewhere in the repo (Demo, MetadataBuilder, Extensions) and enabled by LangVersion latest.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 87.42% 87.42%
=======================================
Files 41 41
Lines 3856 3856
Branches 990 990
=======================================
Hits 3371 3371
Misses 283 283
Partials 202 202 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks
📊 Benchmark Results
PR branch
PR base
|
This reverts commit 9dab406.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the ongoing idiomatic-C# cleanup sweep (see #409, #412, #413). Scope:
PhoneNumbers.Demo,PhoneNumbers.Demo.Tests,PhoneNumbers.MetadataBuilder,PhoneNumbers.Fuzz,PhoneNumbers.PerformanceTest.PhoneNumbers.PerformanceTest/**(Program.cs + all 8 Benchmarks/*.cs) andPhoneNumbers.Fuzz/Program.cs: converted from block-scoped to file-scoped namespaces, matching the convention already used elsewhere in the repo (PhoneNumbers.Demo,PhoneNumbers.MetadataBuilder,PhoneNumbers.Extensions) and enabled byLangVersion latest. Purely mechanical — no logic touched, benchmark[Benchmark]/[Params]attributes and method signatures untouched.PhoneNumbers.Demo,PhoneNumbers.Demo.Tests,PhoneNumbers.MetadataBuilder/Program.cs: read through, already idiomatic (file-scoped namespaces, modern patterns) — no changes made.Test plan
dotnet build csharp/PhoneNumbers.slnx— clean, 0 warningsdotnet build csharp/PhoneNumbers.Demo— clean, 0 warningsdotnet build csharp/PhoneNumbers.PerformanceTest— clean, 0 warningsdotnet build csharp/PhoneNumbers.Fuzz— clean, 0 warningsdotnet test csharp/PhoneNumbers.Demo.Tests— 67/67 passing