style: idiomatic cleanups in ShortNumberInfo - #412
Merged
Conversation
Expression-bodied single-statement methods (GetInstance, RegionDialingFromMatchesNumber, ConnectsToEmergencyNumber, IsEmergencyNumber); is-null/is-not-null pattern matching in place of == null / != null throughout; dropped a redundant else after an unconditional return; added braces to a single-line if for consistency with the rest of the file. No behavior change.
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (52.94%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 87.42% 87.41% -0.01%
==========================================
Files 41 41
Lines 3856 3855 -1
Branches 990 990
==========================================
- Hits 3371 3370 -1
Misses 283 283
Partials 202 202 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 25, 2026
📊 Benchmark Results
PR branch
PR base
|
This was referenced Aug 26, 2026
This was referenced Aug 28, 2026
Closed
Open
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small readability pass over
csharp/PhoneNumbers/ShortNumberInfo.cs, in the same spirit as #409. No behavior change, no restructuring — method-level structure stays a recognizable parallel to the Java source.GetInstance,RegionDialingFromMatchesNumber,ConnectsToEmergencyNumber,IsEmergencyNumber).== null/!= null→is null/is not nullthroughout.elsefollowing an unconditionalreturninGetRegionCodeForShortNumberFromRegionList.ifinMatchNationalNumberfor consistency with the rest of the file.Test plan
dotnet build PhoneNumbers.slnx— clean, 0 warnings (TreatWarningsAsErrors)dotnet test PhoneNumbers.Test/PhoneNumbers.Test.csproj— 414/414 passing on net8.0 and net10.0