Conversation
twcclegg
added a commit
that referenced
this pull request
Aug 26, 2026
- FormatNumberForMobileDialing: collapse if/else assigning the same variable into a ternary (cs/missed-ternary-operator, alert #284). Left the MX/CL/UZ branch's if/else alone (alert #285): its condition carries ~15 lines of explanatory comments that a ternary would make harder to read, not easier. - MaybeExtractCountryCode: replace the `as object ==` reference-equality hack with an explicit ReferenceEquals call and a comment explaining why value equality would be wrong here (the sentinel check needs to distinguish the specific default-object instance from any region's real prefix that happens to equal the literal text). Same behavior, self-documenting instead of looking like a value-equality bug (cs/reference-equality-with-object, alert #31). - ChooseFormattingPatternForNumber: combine the nested ifs, no behavior change (cs/nested-if-statements, alert #255). - GetExampleNumberForType: the empty catch block was silent by design (falls through to `return null`, matching a metadata-quality issue to "no example number" rather than surfacing it) but had no comment saying so; upstream Java logs the exception here instead, which this port doesn't have a logging story for elsewhere either. Added a comment rather than introducing a logging dependency for one call site (cs/empty-catch-block, alert #248). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.