build(deps): bump the phonenumbers_test_minor_patch_updates group in /csharp/PhoneNumbers.Test with 2 updates - #285
Merged
twcclegg merged 1 commit intoFeb 2, 2025
Conversation
Bumps the phonenumbers_test_minor_patch_updates group in /csharp/PhoneNumbers.Test with 2 updates: [coverlet.collector](https://github.com/coverlet-coverage/coverlet) and [xunit](https://github.com/xunit/xunit). Updates `coverlet.collector` from 6.0.3 to 6.0.4 - [Release notes](https://github.com/coverlet-coverage/coverlet/releases) - [Commits](coverlet-coverage/coverlet@v6.0.3...v6.0.4) Updates `xunit` from 2.9.2 to 2.9.3 - [Commits](xunit/xunit@v2-2.9.2...v2-2.9.3) --- updated-dependencies: - dependency-name: coverlet.collector dependency-type: direct:production update-type: version-update:semver-patch dependency-group: phonenumbers_test_minor_patch_updates - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch dependency-group: phonenumbers_test_minor_patch_updates ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
.NET
dependabot
Bot
deleted the
dependabot/nuget/csharp/PhoneNumbers.Test/phonenumbers_test_minor_patch_updates-047346cd1c
branch
February 2, 2025 01:27
twcclegg
added a commit
that referenced
this pull request
Aug 26, 2026
- FormatNumberForMobileDialing: collapse if/else assigning the same variable into a ternary (cs/missed-ternary-operator, alert #284). Left the MX/CL/UZ branch's if/else alone (alert #285): its condition carries ~15 lines of explanatory comments that a ternary would make harder to read, not easier. - MaybeExtractCountryCode: replace the `as object ==` reference-equality hack with an explicit ReferenceEquals call and a comment explaining why value equality would be wrong here (the sentinel check needs to distinguish the specific default-object instance from any region's real prefix that happens to equal the literal text). Same behavior, self-documenting instead of looking like a value-equality bug (cs/reference-equality-with-object, alert #31). - ChooseFormattingPatternForNumber: combine the nested ifs, no behavior change (cs/nested-if-statements, alert #255). - GetExampleNumberForType: the empty catch block was silent by design (falls through to `return null`, matching a metadata-quality issue to "no example number" rather than surfacing it) but had no comment saying so; upstream Java logs the exception here instead, which this port doesn't have a logging story for elsewhere either. Added a comment rather than introducing a logging dependency for one call site (cs/empty-catch-block, alert #248). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the phonenumbers_test_minor_patch_updates group in /csharp/PhoneNumbers.Test with 2 updates: coverlet.collector and xunit.
Updates
coverlet.collectorfrom 6.0.3 to 6.0.4Release notes
Sourced from coverlet.collector's releases.
Commits
2a6f949change log and vnext version number update90b2107update version info (#1731)4e95c92Update changelog and back bump version (#1730)e3717daExclude filter issue (#1728)8eecb42update version and changelog (#1725)Updates
xunitfrom 2.9.2 to 2.9.3Commits
9712244v2.9.3dbba909#3088: Assert.Equivalent throws NotSupportedException for types with getters ...cdf2114Stick to .NET SDK 85716c89Disable NETSDK1215 and NU1902 for .NET 9 SDK6070070TeamCity Reporter. Remove flow id from name of test suites. (#3054)bfd42e0#3053: Class data derived from TheoryData<SomeType[]> is broken5f7494fUpdate assertions and tests3f9460dUpdated READMEd1206d9Update READMEdc5dd04Bump up to v2.9.3-preDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions