docs: Update README.md to provide reason why consumers should keep this nuget package up to date - #286
Merged
Merged
Conversation
…is nuget package up to date
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
Coverage 75.27% 75.27%
=======================================
Files 34 34
Lines 4424 4424
Branches 1001 1001
=======================================
Hits 3330 3330
Misses 885 885
Partials 209 209 ☔ View full report in Codecov by Sentry. |
twcclegg
approved these changes
Feb 24, 2025
twcclegg
added a commit
that referenced
this pull request
Aug 26, 2026
Phonemetadata.cs: all 17 PhoneNumberDesc-typed MergeXxx builder methods share the same if/else-assigns-same-variable shape; collapsed each to a ternary (cs/missed-ternary-operator, alerts #286-#302). Also dropped a redundant int.GetHashCode() call in PhoneMetadata.GetHashCode (cs/useless-gethashcode-call, alert #240). PhoneNumberDesc.cs: dropped two redundant int.GetHashCode() calls in the possibleLength_/possibleLengthLocalOnly_ hash folds (cs/useless-gethashcode-call, alerts #237/#238). int.GetHashCode() returns the int itself, so XOR-ing the value directly is equivalent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes