Skip to content

New network code 71 is available in Turkmenistan - #237

Closed
mgochmuradov wants to merge 1 commit into
twcclegg:mainfrom
mgochmuradov:patch-1
Closed

New network code 71 is available in Turkmenistan#237
mgochmuradov wants to merge 1 commit into
twcclegg:mainfrom
mgochmuradov:patch-1

Conversation

@mgochmuradov

Copy link
Copy Markdown

Added new phone prefix
@mgochmuradov

Copy link
Copy Markdown
Author

Google Libphone PR: google/libphonenumber#3408

@codecov

codecov Bot commented Mar 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.42%. Comparing base (d797db1) to head (22304f0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files          30       30           
  Lines        3499     3499           
  Branches      978      978           
=======================================
  Hits         2919     2919           
  Misses        280      280           
  Partials      300      300           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twcclegg

twcclegg commented Mar 4, 2024

Copy link
Copy Markdown
Owner

The entire resources folder is copied from the Google repo upon its releasesd. See https://github.com/twcclegg/libphonenumber-csharp/blob/main/.github/workflows/create_new_release_on_new_metadata_update.yml

@twcclegg twcclegg closed this Mar 4, 2024
twcclegg added a commit that referenced this pull request Aug 26, 2026
Phonemetadata.cs: all 17 PhoneNumberDesc-typed MergeXxx builder methods
share the same if/else-assigns-same-variable shape; collapsed each to
a ternary (cs/missed-ternary-operator, alerts #286-#302). Also dropped
a redundant int.GetHashCode() call in PhoneMetadata.GetHashCode
(cs/useless-gethashcode-call, alert #240).

PhoneNumberDesc.cs: dropped two redundant int.GetHashCode() calls in
the possibleLength_/possibleLengthLocalOnly_ hash folds
(cs/useless-gethashcode-call, alerts #237/#238).

int.GetHashCode() returns the int itself, so XOR-ing the value
directly is equivalent.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants