Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable IE Compatibility Mode in docs, examples #10790

Merged
merged 2 commits into from
Sep 25, 2013
Merged

Conversation

juthilo
Copy link
Collaborator

@juthilo juthilo commented Sep 24, 2013

Fixes #10788

Should there be explanatory comments above the new tag?
Did I miss anything?

/to @cvrebert @mdo

...because we don't support it and it may cause problems for people
trying to view the docs in IE.
@cvrebert
Copy link
Collaborator

LGTM.

@FagnerMartinsBrack
Copy link

FWIW, It is wise to use that IE crap in the http headers when possible to avoid some edge case stuff, more details.

@mdo
Copy link
Member

mdo commented Sep 24, 2013

Until tests pass, we'll have to wait on this (I rather dislike those emails :p).

Also, we should mention in the http://getbootstrap.com/getting-started/#browsers docs that we include this in the docs.

@juthilo
Copy link
Collaborator Author

juthilo commented Sep 24, 2013

@mdo: @cvrebert said that validation issues don't cause our Travis builds to fail - is that not correct? Both builds I started failed because of that timeout problem at browserstack, AFAICT.

@juthilo
Copy link
Collaborator Author

juthilo commented Sep 24, 2013

I added a note about our use of this tag as requested. Newest Travis build passed (even though it exited with 1, which seems very strange to me...). All good?

@juthilo
Copy link
Collaborator Author

juthilo commented Sep 24, 2013

Ah, Travis was just showing the old log to me. So, validation errors definitely don't cause the tests to fail and merging this in shouldn't cause more notification emails for you, @mdo. :) 💃

@mdo mdo mentioned this pull request Sep 25, 2013
mdo added a commit that referenced this pull request Sep 25, 2013
Disable IE Compatibility Mode in docs, examples
@mdo mdo merged commit cf915f9 into master Sep 25, 2013
@mdo mdo deleted the disable-compatibility-mode branch September 25, 2013 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out a way to disable IE's Compatibility Mode in the docs and examples
5 participants