Use updated Glyphicons to workaround old Android WebKit bug #10778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround an old Android WebKit bug by switching to codepoints within the BMP. Details: http://stackoverflow.com/questions/9241519/webkit-css-content-unicode-bug Extra special thanks to @jankovarik for doing this update. <3 Source: https://www.dropbox.com/s/clh9y6lqtmj01l8/halflings_updated_for_android.zip (As posted in #10106 (comment) )
.glyphicon-briefcase: U+1F4BC -> U+E139 .glyphicon-calendar: U+1F4C5 -> U+E109 .glyphicon-pushpin: U+1F4CC -> U+E146 .glyphicon-paperclip: U+1F4CE -> U+E142 .glyphicon-camera: U+1F4F7 -> U+E046 .glyphicon-lock: U+1F512 -> U+E033 .glyphicon-bell: U+1F514 -> U+E123 .glyphicon-bookmark: U+1F516 -> U+E044 .glyphicon-fire: U+1F525 -> U+E104 .glyphicon-wrench: U+1F527 -> U+E136
|
Excellent! These changes to bootstrap completely fix the issue on Android devices with broken webkit. Tested on Android 2.3.4 and on Android 4.0.3 (both have the webkit bug) and the workaround works perfectly, all icons are properly displayed after this commit is applied. Thanks to everybody for this! |
|
I'll also test this, this week... thanks for getting this in there! |
|
There's no backward compatibility issue here as far as I'm concerned. Looks like a straightforward bug fix.
|
cvrebert
added a commit
that referenced
this pull request
Sep 24, 2013
Use updated Glyphicons to workaround old Android WebKit bug
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10106.
There is a backwards-compatibility concern here, in that the codepoint changes will break stuff that uses the codepoints directly (e.g. entering one directly into HTML, using an
&-escape to represent one in HTML, writing a custom.glyphicon-*equivalent, etc.), as opposed to our.glyphicon-*classes.On the other hand, we didn't document the codepoint numbers or recommend usage of them, so they are arguably not part of our public "API".
(Note: I don't have an Android device of appropriate vintage, so I can't fully test this myself. But the changes make sense theoretically, and I have tested that the icons still display fine on unaffected browsers.)