Old permission logic code removal & tests for new functionality #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure delegate is always set
We don't use these most the time.
M1 to Intel snapshot differences are causing CI to fail.
Tests still fail on CI
FBSnapshotTestCase was renamed to iOSSnapshotTestCase. This update includes functionality to deal with M1 & intel snapshot difference issues and ViewController snapshot convenience methods.
Reduces test code repetition
Camera and mic permissions don't have restricted permission statuses
Utilize helper functions and remove redundant accessRequests. Access is now requested upon view appearing.
…ICORE-4182-fast-track-camera-and-microphone-permissions # Conflicts: # KanvasExample/KanvasExample.xcodeproj/project.pbxproj # KanvasExample/KanvasExampleTests/Camera/CameraPermissionsTests.swift
This functionality is now included within v8.0.0
Replace 10% overall tolerance with 2% perPixel Tolerance
…an/ICORE-4182-fast-track-camera-and-microphone-permissions
This is to enable snapshots to pass on M1 and intel run simulators
…m/tumblr/kanvas-ios into declan/ICORE-4828-code-removal-and-test-update
I think this was originally above the mock occupying the same file which has since been rewritten.
Deco354
changed the title
Deco354
changed the title
…an/ICORE-4828-code-removal-and-test-update # Conflicts: # KanvasExample/KanvasExample.xcodeproj/project.pbxproj # KanvasExample/KanvasExampleTests/Camera/CameraPermissionsTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it is
Removes code that is no longer necessary, adds new tests for new permissions logic, implements dependency injection to ease testing and adapts new snapshot tests to be M1 compatible.
How to test
CI is 🟢 and permission logic laid out in this PR still works.