Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified permission flow #133

Merged
merged 21 commits into from
Apr 25, 2022
Merged

Simplified permission flow #133

merged 21 commits into from
Apr 25, 2022

Conversation

Deco354
Copy link
Collaborator

@Deco354 Deco354 commented Apr 22, 2022

JIRA: ICORE-4812
P2: https://wp.me/pbzQyC-248

What it does

This changes how we ask the user for camera and microphone permissions. Apple recently rejected our review as they didn't want an intermediary screen where users can choose whether to display apples official permission requests.

Everything here has been reviewed for orangina as part of this PR and is currently being used within Orangina by pointing at a copy of this branch.

Before After
Simulator Screen Recording - iPhone 8 - 2022-04-22 at 10 11 38 Simulator Screen Recording - iPhone 8 - 2022-04-22 at 10 13 26

How to test

This might not need testing as it's already been tested when added to Orangina, although in case the example app behaves significantly differently and you'd like to check I've included the testing instructions from the original PR. There's also another PR that will be merged in after this one adding automated tests and removing code, it might be better to test this PR instead

Use a real device, resetting the app permission settings on simulator is a bit tricky.

Unknown permissions

  • Goto Settings > General > Reset > Reset Location & Privacy
  • Open photo screen and two alerts should appear

Accepted permissions

  • Goto Settings > General > Reset > Reset Location & Privacy
  • Open photo screen and accept both permission alerts
  • Result: Camera and mic should be fully accessible
  • Go back and open screen
    Result: Camera and mic should be fully accessible

Denied permissions -

  • Goto Settings > General > Reset > Reset Location & Privacy
  • Open photo screen
  • Deny Camera and Mic access
  • Result: Settings redirect screen should appear and no access to camera is granted
  • Go back and reopen screen
  • Result: No permission alerts should appear. Settings redirect screen should appear and no access to camera is granted
  • Kill app and open screen
  • Result: Settings redirect screen should appear and no access to camera is granted
  • repeat these steps this time only selecting one of the camera or mic permissions to reject

Stop settings button from being disabled after camera permission has
been given but microphone permission hasn't.
This button used to be the camera access button.
The Views have been quite radically changed these should rewritten
or rerecorded once the fix is released.
The existing constraints can't handle changes to their size
when changing the text.
The button will never be disabled.
Our coding standards are to use the value but we need to use the
existing Orangina translations here.
Copy link
Collaborator

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Looks good to me!

@Deco354 Deco354 merged commit 433aef3 into main Apr 25, 2022
@Deco354 Deco354 deleted the declan/ICORE-4182-permission-flow branch April 25, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants