Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make final classes that are not extendible #164

Merged
merged 2 commits into from
Nov 21, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## 1.5.0 - (next release)

### Added
- Make `final` classes that are not extendible https://github.com/xcodeswift/xcproj/pull/164 by @pepibumur.

### Fixed
- Fix `PBXProject` `productRefGroup` comment https://github.com/xcodeswift/xcproj/pull/161 by @allu22
- Fix deprecation warnings for `PBXProj` objects usage https://github.com/xcodeswift/xcproj/pull/162 by @rahul-malik
Expand Down
3 changes: 2 additions & 1 deletion Sources/xcproj/PBXAggregateTarget.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for a build target that aggregates several others.
public class PBXAggregateTarget: PBXTarget {
final public class PBXAggregateTarget: PBXTarget {

}

Expand All @@ -12,4 +12,5 @@ extension PBXAggregateTarget: PlistSerializable {
func plistKeyAndValue(proj: PBXProj) -> (key: CommentedString, value: PlistValue) {
return plistValues(proj: proj, isa: PBXAggregateTarget.isa)
}

}
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXBuildFile.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This element indicates a file reference that is used in a PBXBuildPhase (either as an include or resource).
public class PBXBuildFile: PBXObject, Hashable {
final public class PBXBuildFile: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXContainerItemProxy.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element to decorate a target item.
public class PBXContainerItemProxy: PBXObject, Hashable {
final public class PBXContainerItemProxy: PBXObject, Hashable {

public enum ProxyType: UInt, Decodable {
case nativeTarget = 1
Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXCopyFilesBuildPhase.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for the copy file build phase.
public class PBXCopyFilesBuildPhase: PBXBuildPhase, Hashable {
final public class PBXCopyFilesBuildPhase: PBXBuildPhase, Hashable {

public enum SubFolder: UInt, Decodable {
case absolutePath = 0
Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXFileElement.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This element is an abstract parent for file and group elements.
public class PBXFileElement: PBXObject, Hashable {
final public class PBXFileElement: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXFileReference.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import PathKit

/// A PBXFileReference is used to track every external file referenced by
/// the project: source files, resource files, libraries, generated application files, and so on.
public class PBXFileReference: PBXObject, Hashable {
final public class PBXFileReference: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXFrameworksBuildPhase.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for the framework link build phase.
public class PBXFrameworksBuildPhase: PBXBuildPhase, Hashable {
final public class PBXFrameworksBuildPhase: PBXBuildPhase, Hashable {

public override var buildPhase: BuildPhase {
return .frameworks
Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXGroup.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Foundation

public class PBXGroup: PBXObject, Hashable {
final public class PBXGroup: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXHeadersBuildPhase.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Foundation
import PathKit

/// This is the element for the framework headers build phase.
public class PBXHeadersBuildPhase: PBXBuildPhase, Hashable {
final public class PBXHeadersBuildPhase: PBXBuildPhase, Hashable {

public override var buildPhase: BuildPhase {
return .headers
Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXNativeTarget.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for a build target that produces a binary content (application or library).
public class PBXNativeTarget: PBXTarget {
final public class PBXNativeTarget: PBXTarget {

}

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXProj.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Foundation
import PathKit

/// Represents a .pbxproj file
public class PBXProj: Decodable {
final public class PBXProj: Decodable {
public class Objects: Equatable {
// MARK: - Properties
public var buildFiles: ReferenceableCollection<PBXBuildFile> = [:]
Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXProjEncoder.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ extension PlistSerializable {
}

/// Encodes your PBXProj files to String
class PBXProjEncoder {
final class PBXProjEncoder {

var indent: UInt = 0
var output: String = ""
Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXProject.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Foundation

public class PBXProject: PBXObject, Hashable {
final public class PBXProject: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXReferenceProxy.swift
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Foundation
/// A proxy for another object which might belong to another project
/// contained in the same workspace of the document.
/// This class is referenced by PBXTargetDependency.
public class PBXReferenceProxy: PBXObject, Hashable {
final public class PBXReferenceProxy: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXResourcesBuildPhase.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for the resources copy build phase.
public class PBXResourcesBuildPhase: PBXBuildPhase, Hashable {
final public class PBXResourcesBuildPhase: PBXBuildPhase, Hashable {

public override var buildPhase: BuildPhase {
return .resources
Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXShellScriptBuildPhase.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for the shell script build phase.
public class PBXShellScriptBuildPhase: PBXBuildPhase, Hashable {
final public class PBXShellScriptBuildPhase: PBXBuildPhase, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXSourcesBuildPhase.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for the sources compilation build phase.
public class PBXSourcesBuildPhase: PBXBuildPhase, Hashable {
final public class PBXSourcesBuildPhase: PBXBuildPhase, Hashable {

public override var buildPhase: BuildPhase {
return .sources
Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXTargetDependency.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for referencing other targets through content proxies.
public class PBXTargetDependency: PBXObject, Hashable {
final public class PBXTargetDependency: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/PBXVariantGroup.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

// This is the element for referencing localized resources.
public class PBXVariantGroup: PBXObject, Hashable {
final public class PBXVariantGroup: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/XCBuildConfiguration.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for listing build configurations.
public class XCBuildConfiguration: PBXObject, Hashable {
final public class XCBuildConfiguration: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/XCConfig.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import PathKit
public typealias XCConfigInclude = (include: Path, config: XCConfig)

/// .xcconfig configuration file.
public class XCConfig {
final public class XCConfig {

// MARK: - Attributes

Expand Down
2 changes: 1 addition & 1 deletion Sources/xcproj/XCConfigurationList.swift
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import Foundation

/// This is the element for listing build configurations.
public class XCConfigurationList: PBXObject, Hashable {
final public class XCConfigurationList: PBXObject, Hashable {

// MARK: - Attributes

Expand Down
Loading