Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make final classes that are not extendible #164

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Make final classes that are not extendible #164

merged 2 commits into from
Nov 21, 2017

Conversation

pepicrft
Copy link
Contributor

@pepicrft pepicrft commented Nov 21, 2017

Partially resolves #163

Short description πŸ“

Apple recommends you to make final those classes that are not extendible.

Solution πŸ“¦

Review classes and make final those that are not supposed to be extended.

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

  • Add final keyword to non-extendible classes

GIF

gif

@pepicrft pepicrft added this to the 1.5.0 milestone Nov 21, 2017
@pepicrft pepicrft self-assigned this Nov 21, 2017
@pepicrft pepicrft requested a review from a team November 21, 2017 07:40
@pepicrft pepicrft merged commit f582cca into master Nov 21, 2017
@pepicrft pepicrft deleted the final branch November 21, 2017 10:24
@rahul-malik
Copy link
Contributor

Awesome, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift optimizations
2 participants