Refactor dataset creation interface #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t an argument anymore.
Collaborator
Author
|
This is just a first suggestion. Looking for feedback on the function |
hmgaudecker
reviewed
Jul 23, 2025
Collaborator
hmgaudecker
left a comment
hmgaudecker
left a comment
There was a problem hiding this comment.
Had a look, but lacking the context... 🤷 No rush.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main function inside
dataset_merging/helper.pyis the user-facing interface for creating the dataset the user is interested in. Hence, the function should be robust, yet lean.The function depends on user-specified input (variables and timeframe of interest) and output from previous tasks (mainly the "merged metadata mapping" that maps variable names to data file names).
The task needs to depend on this mapping for the completeness of the DAG, yet the user should not worry about specifying it for creating a dataset.