Agg decorator #873
Merged
Agg decorator #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oupCreationFunction and add so-far-useless new attributes.
hmgaudecker
changed the base branch from
main
to
collect-components-of-namespaces
…' into agg-decorator
### What problem do you want to solve? Add policy test data for METTSIM. Todo - [x] Introduce `resource_dir` arg for parameters in `set_up_policy_environment`, it currently reads in GETTSIM parameters. - [x] Fix testing infrastructure such that a merged df is used for testing. Currently, we only test the first expected output column in each testing yaml. --------- Co-authored-by: Hans-Martin von Gaudecker <[email protected]>
hmgaudecker
force-pushed
the
agg-decorator
branch
from
f6f38ac to
7d2adbd
Compare
This is just #864 by @timmens, the merge did not work out and we need to re-do that. --------- Co-authored-by: Tim Mensinger <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…nomics/gettsim into agg-decorator
…te_time_conversions (not used yet).
…nomics/gettsim into agg-decorator
…nomics/gettsim into agg-decorator
…unction -> TimeConversionFunction.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## collect-components-of-namespaces #873 +/- ##
===================================================================
Coverage ? 83.08%
===================================================================
Files ? 145
Lines ? 5710
Branches ? 0
===================================================================
Hits ? 4744
Misses ? 966
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
### What problem do you want to solve? `join_numpy` is not jit compatible, I replaced it with a generic join function that uses either Jax or Numpy depending on the Flag in config.py. The Input checks are now the responsibility of the user of the function. If there are duplicate Private Keys the first encountered value will be used. If a foreign key is missing the user-supplied default value will be used. ### Todo - [x] Write `join` thet supports both Jax and Numpy - [x] Add test --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Hans-Martin von Gaudecker <[email protected]>
hmgaudecker
merged commit 46af123
into
collect-components-of-namespaces
5 of 7 checks passed
This was referenced Apr 18, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
Fix #870 and related things. In particular, defer some checks so that they are only done for variables that are present / set start/end dates of explicit aggregation functions so they are derived from source object.