Add join_jax #863
Merged
Add join_jax #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj023
changed the base branch from
collect-components-of-namespaces
to
agg-decorator
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
hmgaudecker
approved these changes
Apr 17, 2025
Collaborator
hmgaudecker
left a comment
hmgaudecker
left a comment
There was a problem hiding this comment.
Excellent, thank you!!!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## agg-decorator #863 +/- ##
=================================================
- Coverage 83.12% 83.08% -0.05%
=================================================
Files 145 145
Lines 5725 5710 -15
=================================================
- Hits 4759 4744 -15
Misses 966 966 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do you want to solve?
join_numpyis not jit compatible, I replaced it with a generic join function that uses either Jax or Numpy depending on the Flag in config.py. The Input Checks are now resposibility of the user of the function. If there are duplicate Private Keys the first encountered value will be used. If a foreign key is missing the user-supplied default value will be used.Todo
jointhet supports both Jax and Numpy