Update es2017 to es2019 in React Native base #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @retyui pointed out our new minimal iOS version for RN 0.69 is 12.4 - react-native-community/react-native-template-typescript#275 - facebook/react-native@982ca30 We've updated our template too now - react-native-community/react-native-template-typescript#276 I bumped our Hermes podspec earlier as well - facebook/react-native#33939 - facebook/react-native@f56d701 Unless there's reason to keep our recommended TSConfig base pre-0.69
Member
|
Yeah, I think this makes sense to me for the base. 👍🏻 Switch RN to use this could be a good call too - then projects only have the tsconfig options for their unique needs in their tsconfig |
6 tasks
Contributor
Author
|
cool made the PR ^ also considering react-native-community/react-native-template-typescript#281 (comment) as follow-up hopefully we're good to merge 👍 |
leotm
added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Jun 30, 2022
leotm
changed the title
Member
|
Agree |
radko93
pushed a commit
to react-native-community/react-native-template-typescript
that referenced
this pull request
Jun 30, 2022
* Add TODO * Add devdep @tsconfig/react-native v2 * Extend recommended React Native TSConfig base * Doc recommended React Native TSConfig base * Remove tsc --init comments now that we're extending * Remove es2019 lib override - merged in tsconfig/bases#116 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended * Remove forceConsistentCasingInFileNames override - merged in tsconfig/bases#118 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended
This was referenced Jul 6, 2022
yardcooper
pushed a commit
to yardcooper/react-native-template
that referenced
this pull request
May 1, 2023
* Add TODO * Add devdep @tsconfig/react-native v2 * Extend recommended React Native TSConfig base * Doc recommended React Native TSConfig base * Remove tsc --init comments now that we're extending * Remove es2019 lib override - merged in tsconfig/bases#116 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended * Remove forceConsistentCasingInFileNames override - merged in tsconfig/bases#118 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended
J534-spec
added a commit
to J534-spec/react-native-template-typescript
that referenced
this pull request
Oct 8, 2025
* Add TODO * Add devdep @tsconfig/react-native v2 * Extend recommended React Native TSConfig base * Doc recommended React Native TSConfig base * Remove tsc --init comments now that we're extending * Remove es2019 lib override - merged in tsconfig/bases#116 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended * Remove forceConsistentCasingInFileNames override - merged in tsconfig/bases#118 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda follow-up to
As @retyui pointed out 🙏 our new minimal iOS version for RN 0.69 is 12.4
We've updated our template too now
I bumped our Hermes podspec earlier as well
Unless there's reason to keep our current recommended TSConfig base pre-0.69 (iOS 11)
cc @radko93 @orta @cortinico
nit: May be worth considering extending this instead in our RN TS template, like we do in our ESLint @react-native-community ruleset - I don't mind creating a PR