-
Notifications
You must be signed in to change notification settings - Fork 394
Extend recommended React Native TSConfig base #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, can you update this branch with master and see if it runs the lint action? |
|
sure ^ how do you feel about what @orta mentioned btw |
|
Yeah, IMO, you should present an empty tsconfig if you're going with the |
|
from messing around earlier but sure an empty tsconfig w |
|
and happy to remove any overrides like es2019 once merged in |
- merged in tsconfig/bases#116 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended
- merged in tsconfig/bases#118 - now in https://github.com/tsconfig/bases/blob/main/bases/react-native.json - no longer needed since extended
|
LGTM, great work! |



Context
To keep our recommended React Native TSConfig base as the source
yarn set version classicts --initcomment boilerplate (can still remove further)es2019overrideforceConsistentCasingInFileNamesoverrideHave a think if skipLibCheck should be recommended for React Native, we do in few others
Remove duplicate rule overridesKeep duplicate rule overrides for visibility