merge#8
Merged
tsachiherman merged 6 commits intotsachiherman:masterfrom Jun 26, 2019
Merged
Conversation
as suggested in #80
Accept API tokens provided in a bearer token format.
We were compiling without golang race detector when we intended the opposite for e2e tests. In addition, this change: - tries to kill algod processes before e2e tests panic, to stop littering machines on failure - fixes a kmd data race due to value receivers on kmd server - excludes kmd binary from -race compilation for e2e tests. Notably, computing Scrypt.Key in memory/cpu-constrained environments took the order of minutes when the race detector is enabled, essentially breaking kmd if compiled with -race, and causing test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explain the goal of this change and what problem it is solving.
Test Plan
How did you test these changes? Please provide the exact scenarios you tested in as much detail as possible including commands, output and rationale.