Accept API Token in Authorization Header#90
Merged
winder merged 6 commits intoalgorand:masterfrom Jun 26, 2019
Merged
Conversation
rotemh
suggested changes
Jun 25, 2019
rotemh
suggested changes
Jun 25, 2019
rotemh
approved these changes
Jun 26, 2019
algorandskiy
pushed a commit
to algorandskiy/go-algorand
that referenced
this pull request
May 23, 2020
Remove LogicSigMaxCost check from eval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We have a metrics endpoint to provide prometheus style metrics, it also requires the
X-Algo-API-Token: <token>header. Some tools which are able to consume this endpoint, like Telegraf, assume authorization tokens will be provided as bearer tokens, likeAuthorization: Bearer <token>. So this adds that as a fallback.Test Plan
Make sure both forms still work: