Skip to content

feat(cua-driver): configure embedded daemon overlay - #3280

Merged
f-trycua merged 3 commits into
mainfrom
feat/embedded-host-no-overlay
Aug 20, 2026
Merged

feat(cua-driver): configure embedded daemon overlay#3280
f-trycua merged 3 commits into
mainfrom
feat/embedded-host-no-overlay

Conversation

@injaneity

@injaneity injaneity commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

summary

  • add a default-false no_overlay option to EmbeddedDriverHostOptions
  • apply --no-overlay to the SDK-owned serve process only when requested
  • regenerate Python and TypeScript bindings and cover default/enabled arguments

Refs #3278.

candidate

  • exact SHA: f7ed2fd4250153e93b43c84baa31bb589a49e1a0
  • rebased onto ee09e869727ce1f80793b0dd830a29139cb6fffa

validation

  • focused Rust default-behavior test: 1 passed
  • TypeScript generated SDK and lifecycle suite: 6 passed
  • Python generated SDK and lifecycle suite on Python 3.12: 4 passed
  • UniFFI generated-binding drift check: passed
  • git diff --check: passed

The base advances contained only unrelated docs-validation and local-signing changes, so they did not invalidate the focused local runtime evidence. Fresh Windows and Linux GitHub checks are required on this exact rebased candidate before merge. Existing macOS duplicate Swift-symbol linker warnings remained non-fatal during local binding generation; no macOS certification is claimed.

@injaneity
injaneity marked this pull request as ready for review August 20, 2026 08:17
@injaneity
injaneity requested a review from f-trycua as a code owner August 20, 2026 08:17
Base automatically changed from fix/embedded-host-telemetry-env to main August 20, 2026 16:06
@f-trycua
f-trycua force-pushed the feat/embedded-host-no-overlay branch 2 times, most recently from a759cab to 044af3f Compare August 20, 2026 18:07

@f-trycua f-trycua left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified at exact head 044af3f097d16caa0e5b5e85bb7ac591c7e5c97a: the overlay remains opt-in, the generated Python and TypeScript options default to disabled, focused Rust and SDK lifecycle tests pass, and generated bindings are current. Merge only after the fresh Windows/Linux and required checks finish green.

@f-trycua
f-trycua force-pushed the feat/embedded-host-no-overlay branch from 044af3f to 7b1dee7 Compare August 20, 2026 18:12
@f-trycua
f-trycua force-pushed the feat/embedded-host-no-overlay branch from 7b1dee7 to f7ed2fd Compare August 20, 2026 18:29

@f-trycua f-trycua left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head f7ed2fd4250153e93b43c84baa31bb589a49e1a0: no_overlay is opt-in, affects only the SDK-owned daemon launch, defaults remain unchanged across Rust/Python/TypeScript, generated bindings match, and contributor authorship is preserved. Merge only after all fresh exact-head Windows/Linux and required checks finish green.

@f-trycua
f-trycua merged commit 3ae080d into main Aug 20, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants