fix(cua-driver): preserve embedded telemetry preference - #3277
Merged
Conversation
injaneity
marked this pull request as ready for review
August 20, 2026 06:24
injaneity
marked this pull request as draft
August 20, 2026 07:04
injaneity
marked this pull request as ready for review
August 20, 2026 08:17
This was referenced Aug 20, 2026
f-trycua
approved these changes
Aug 20, 2026
f-trycua
left a comment
Collaborator
There was a problem hiding this comment.
Approved after exact-head review. The change is narrowly scoped to the embedded child-environment allowlist, preserves both supported telemetry variables, and covers inherited plus explicit override behavior. All required checks are green; no desktop E2E is needed for this deterministic environment-filter change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
CUA_DRIVER_RS_TELEMETRY_ENABLEDwhen an SDK-owned embedded host builds the private daemon environmentCUA_TELEMETRY_ENABLEDcompatibility name as wellwhy
EmbeddedCuaDriverHostclears the child environment and restores an allowlisted subset. Both supported Cua Driver telemetry settings were missing from that allowlist, so embedding hosts could not carry their telemetry preference into the private daemon. Passing either name throughEmbeddedDriverHostOptions.environmentalso failed because explicit overrides use the same filter.This is the first focused fix found while evaluating replacement of downstream private-daemon lifecycle code with the SDK-owned host. Overlay controls and stderr diagnostics remain separate focused changes in the dependent PRs. Host-process ownership remains unchanged.
Closes #3276.
validation
cargo fmt --all -- --checkcargo test --locked -p cua-driver-sdk— 52 passedgit diff --checkThe macOS linker emitted the existing duplicate Swift symbol warnings; the test suite passed. No desktop E2E is required because this change only modifies the SDK child-environment allowlist and has deterministic unit coverage.