chore(cua-driver-rs)(install): install-local.sh defaults to the Rust backend - #1707
Conversation
…backend
The local/dev installer now picks the Rust backend by default on every
host. The production curl-pipe-bash `install.sh` stays unchanged — it
keeps the Swift default on macOS until cua-driver-rs flips from
experimental to stable.
Why now: the Rust port is the active dev target across all three
platforms, has the full integration-test surface attached (crates/
cua-driver/tests/harness_*_test.rs), and devs working off `install-
local.sh` are the audience that's been using `--experimental-rust` /
`--backend=rust` reflexively for weeks. Flipping the default cuts a
flag from every checked-out-tree install.
Flag handling:
- `--backend=swift` now sets USE_SWIFT_BACKEND=1 (was a no-op since
Swift was the default). Errors on non-Darwin since there's no
Swift install path there.
- `--backend=rust` is now the no-op (matches the default).
- `--experimental-rust` accepted as legacy alias, also no-op now.
Kept so any script or doc passing it keeps working.
No behavior change to `install.sh`, `install.ps1`, or either
helper. Single-file edit; bash -n clean; verified dispatch:
- bare invocation → _install-local-rust.sh
- `--backend=swift` on macOS → _install-local-swift.sh
- `--backend=swift` on Linux → hard-error before helper exec
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe install-local.sh wrapper is refactored to default to the Rust backend across all platforms and to permit Swift selection only on macOS. Documentation, flag parsing, and dispatch logic are updated to enforce this behavior while maintaining backward compatibility for the legacy ChangesRust-default multi-backend installer
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Flip the default backend in
libs/cua-driver/scripts/install-local.shfrom Swift to Rust on every host. The production curl-pipe-bashinstall.shis unchanged — it still keeps the Swift default on macOS until cua-driver-rs flips from experimental to stable.Why
install-local.shis the developer / checked-out-tree installer. Its audience is people working on the Rust port (across Windows / Linux / macOS) who've been typing--experimental-rustor--backend=rustreflexively for weeks.crates/cua-driver/tests/harness_{appkit,swiftui,wpf,winui3,…}_test.rs).Flag semantics after this change
--backend=swift--backend=rust--experimental-rustBehavior verification
bash -nclean.What this does NOT touch
install.sh(production curl-pipe-bash) — Swift default on macOS staysinstall.ps1/install-local.ps1(Windows) — already Rust-only on Windows_install-local-{rust,swift}.sh) — unchanged--backend=swiftor--backend=rust— they keep doing what they askedTest plan
bash -n libs/cua-driver/scripts/install-local.shcleanbash -xfor the four argv shapes abovebash install-local.sh --releaseon this Mac (builds the Rust release; ~1 min)Rollback
Revert this commit. Single-file, 51-line diff. Anyone caught off-guard can pass
--backend=swiftto get the old behavior on macOS.🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation