fix(cua-driver-rs)(scripts): point Rust dev installers at libs/cua-driver/rust/ - #1676
Conversation
…iver/rust/ Follow-up to #1674. The Rust dev installers (install-local.ps1 + _install-local-rust.sh) moved up from libs/cua-driver/rust/scripts/ to libs/cua-driver/scripts/ in that PR, but their internal source-dir resolution wasn't adjusted — \$ScriptDir/.. now lands at libs/cua-driver/ (no Cargo.toml) instead of the Cargo workspace at libs/cua-driver/rust/. Running install-local.ps1 against a fresh checkout failed with `could not find Cargo.toml`. Fixes: - install-local.ps1: - \$RepoRoot now resolves to \$ScriptDir/../rust - \$HintsTxt now points at \$ScriptDir/post-install-hints.txt directly (used to go through \$RepoRoot/../cua-driver/scripts/ — both that indirection and the cwd it relied on are gone) - _install-local-rust.sh: - REPO_ROOT now resolves to \$SCRIPT_DIR/../rust - SOURCE_SKILLS reads from \$REPO_ROOT/Skills/cua-driver-rs (the Cargo workspace tree) instead of \$SCRIPT_DIR/../Skills which is now the canonical scripts/ parent - HINTS_TXT now resolves to \$SCRIPT_DIR/post-install-hints.txt
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughInstallation scripts for the CUA driver are updated to compute the Rust workspace root from ChangesRust workspace and hints path resolution
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Follow-up to #1674. The Rust dev installers moved up from `libs/cua-driver/rust/scripts/` to `libs/cua-driver/scripts/` in that PR, but their internal source-dir resolution wasn't adjusted. Running `.\install-local.ps1` against a fresh checkout failed with:
```
error: could not find `Cargo.toml` in `C:\Users\cuademo\cua\libs\cua-driver` or any parent directory
```
$ScriptDir/.. used to resolve to the Cargo workspace at `libs/cua-driver/rust/`. After the move it lands at `libs/cua-driver/` (no Cargo.toml).
Fix
The Swift dev installer (`_install-local-swift.sh`) was already pointed at `swift/` in #1674 — only the Rust side needed this follow-up.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit