Add node ID in resource policy #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Jakob-Naucke I forgot, is it trustee always checking pcr8 with the initdata? |
Contributor
Author
|
Yes. Setting initdata like in this PR with upstream Trustee will give you: |
Contributor
|
The PR latchset/clevis-pin-trustee#12 has been merged so we can avoid to branch it and directly refer main |
Contributor
|
But otherwise, LGTM |
Jakob-Naucke
force-pushed
the
id-res-policy
branch
from
efde407 to
ca1dd8e
Compare
Contributor
Author
|
|
Broken by the Trustee that requires them, infeasible to keep multiple versions running. Signed-off-by: Jakob Naucke <[email protected]>
- Add qcows & Trustee keys to .gitignore - Instruct key creation in README Signed-off-by: Jakob Naucke <[email protected]>
Requires initdata-compatible trustee-attester [1] and clevis-pin-trustee [2]. Uses a Trustee that does not verify initdata for now [3]. [1] confidential-containers/guest-components#1163 [2] latchset/clevis-pin-trustee#12 [3] https://github.com/confidential-clusters/trustee/tree/skip-verify-initdata Signed-off-by: Jakob Naucke <[email protected]>
Jakob-Naucke
force-pushed
the
id-res-policy
branch
from
ca1dd8e to
9cb7601
Compare
Contributor
Author
|
I could also convert to draft instead of writing a comment. Anyway, ready for review. |
Contributor
|
@Jakob-Naucke we don't want this to be merged right? |
Contributor
Author
|
Yes we do (modulo review of course), I removed the broken workflows. Let me cross out the DNM for clarity which I should have done right away. |
alicefr
approved these changes
Nov 25, 2025
Jakob-Naucke
merged commit 853f337
into
trusted-execution-clusters:main
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires initdata-compatible trustee-attester [1] and clevis-pin-trustee [2]. Uses a Trustee that does not verify initdata for now [3].
[1] confidential-containers/guest-components#1163
[2] latchset/clevis-pin-trustee#12
[3] https://github.com/confidential-clusters/trustee/tree/skip-verify-initdata