trustee-attester: Allow passing initdata #1163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not use the RB formatter, which drops spaces and alternates bold/non-bold formatting which was probably unintended. - Indent get-resource subcommand and move below options. Signed-off-by: Jakob Naucke <[email protected]>
Jakob-Naucke
force-pushed
the
trustee-attester-initdata
branch
from
d0dd922 to
f18b308
Compare
fitzthum
approved these changes
Oct 31, 2025
Member
fitzthum
left a comment
fitzthum
left a comment
There was a problem hiding this comment.
LGTM
It might be good to note somewhere that this is the plaintext init-data and that Trustee will expect the hash of the init-data to have been already measured somehow.
Add `--initdata` flag to trustee-attester, taking initdata as a string. Signed-off-by: Jakob Naucke <[email protected]>
Jakob-Naucke
force-pushed
the
trustee-attester-initdata
branch
from
f18b308 to
15269b0
Compare
Member
Author
|
Thanks for the fast review. Have added a remark on initdata measurement in the man page. |
Xynnn007
approved these changes
Nov 1, 2025
Jakob-Naucke
added a commit
to Jakob-Naucke/trusted-cluster-investigations
that referenced
this pull request
Nov 12, 2025
Requires initdata-compatible trustee-attester [1] and clevis-pin-trustee [2]. Uses a Trustee that does not verify initdata for now [3]. [1] confidential-containers/guest-components#1163 [2] latchset/clevis-pin-trustee#12 [3] https://github.com/confidential-clusters/trustee/tree/skip-verify-initdata Signed-off-by: Jakob Naucke <[email protected]>
Jakob-Naucke
added a commit
to Jakob-Naucke/trusted-cluster-investigations
that referenced
this pull request
Nov 12, 2025
Requires initdata-compatible trustee-attester [1] and clevis-pin-trustee [2]. Uses a Trustee that does not verify initdata for now [3]. [1] confidential-containers/guest-components#1163 [2] latchset/clevis-pin-trustee#12 [3] https://github.com/confidential-clusters/trustee/tree/skip-verify-initdata Signed-off-by: Jakob Naucke <[email protected]>
Jakob-Naucke
added a commit
to Jakob-Naucke/trusted-cluster-investigations
that referenced
this pull request
Nov 19, 2025
Requires initdata-compatible trustee-attester [1] and clevis-pin-trustee [2]. Uses a Trustee that does not verify initdata for now [3]. [1] confidential-containers/guest-components#1163 [2] latchset/clevis-pin-trustee#12 [3] https://github.com/confidential-clusters/trustee/tree/skip-verify-initdata Signed-off-by: Jakob Naucke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--initdataflag to trustee-attester, taking initdata as a string.Preliminary change: some manpage fixes
cc @uril