Smaller keyhandle length #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szszszsz Is my understanding correct that this change is backwards-compatible because we can still deserialize the old key handles that include the now absent fields? |
|
That's correct. This should not affect previous registrations at all. What's left is to make sure, if the extension fields can be safely skipped, or do they need to be encoded, and checked on assertion getting with the browser's request. By the way, here are my notes from testing the key handles' lengths: |
szszszsz
force-pushed
the
sz-smaller-keyhandle-length
branch
from
9396680
to
c9c70c3
Compare
szszszsz
added a commit
to Nitrokey/fido-authenticator
that referenced
this pull request
Jan 15, 2022
Remove some fields from credential data serialization while making credential ID. Reduces key handle size by around 30% (from ~320 to ~220). Tested on Gitlab, and this patch makes it working correctly (both registering and signing, as opposed to 500 error code returned otherwise). Presumably the hidden limit is 255 bytes, which would be compatible with CTAP1. Related: trussed-dev#8
|
Note: we have reports that this is not backwards compatible for some users. |
Some services do not accept arbitrary long key handle (aka Credential ID), which makes the FIDO operations failing. This patch removes some fields from credential data serialization while making credential ID, and with this it reduces key handle size by around 30% (from ~320 to ~220 using test site [1]). Tested on Gitlab, and this patch makes it working correctly (both registering and signing, as opposed to 500 error code returned otherwise). Presumably the hidden limit is 255 bytes, which would be compatible with CTAP1. Resident Keys stay the same, with full metadata stored on the device. [1] webauthn.bin.coffee
szszszsz
force-pushed
the
sz-smaller-keyhandle-length
branch
from
c9c70c3
to
ade608c
Compare
|
Rebased on |
|
Closing this PR in favor of a major rework (which includes your ID shortening). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some fields from credential data serialization while making credential ID.
Reduces key handle size by around 30% (from ~320 to ~220). Tested on Gitlab, and this patch makes it working correctly (both registering and signing, as opposed to 500 error code returned otherwise).
Presumably the hidden limit is 255 bytes, which would be compatible with CTAP1.
cc @jans23 @robin-nitrokey
To do: