Less RAM #11
Merged
Less RAM #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some services do not accept arbitrary long key handle (aka Credential ID), which makes the FIDO operations failing. This patch removes some fields from credential data serialization while making credential ID, and with this it reduces key handle size by around 30% (from ~320 to ~220 using test site [1]). Tested on Gitlab, and this patch makes it working correctly (both registering and signing, as opposed to 500 error code returned otherwise). Presumably the hidden limit is 255 bytes, which would be compatible with CTAP1. Resident Keys stay the same, with full metadata stored on the device. [1] webauthn.bin.coffee
Merged
|
Probably a dumb question, but anyway - may I ask how do I get notified when this change gets its way to the firmware release? Having issues with too long key handle in a few services. Thanks! |
|
You can "Watch for releases" of https://github.com/solokeys/solo2 (top-right, watch, custom, releases) or check the https://github.com/solokeys/solo2/releases page by hand, for now. I have a firmware that's basically ready except I don't have a working NFC testing setup and I think I may have borked it (as this firmware "doesn't work" on my Pixel 5). |
|
Any news on a release of a new firmware that would render the Solo2 usable on the other half of the internet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cargo fmtis done at the very end, so the significant changes can be tracked commit by commit.