Improve Azure Storage detection #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rgmz
force-pushed
the
feat/update-azurestorage
branch
2 times, most recently
from
2069c0d to
bd0600b
Compare
|
I would love to see this reach a release. The existing detector, for me, missed many AzureStorage keys that this work here does detect. |
2 tasks
rgmz
force-pushed
the
feat/update-azurestorage
branch
3 times, most recently
from
93321d8 to
c978fae
Compare
rgmz
force-pushed
the
feat/update-azurestorage
branch
8 times, most recently
from
9a29cef to
51ce131
Compare
rgmz
force-pushed
the
feat/update-azurestorage
branch
from
51ce131 to
7a501f4
Compare
rgmz
force-pushed
the
feat/update-azurestorage
branch
2 times, most recently
from
9ea1cd5 to
181ae6e
Compare
rgmz
force-pushed
the
feat/update-azurestorage
branch
from
181ae6e to
2b3eff9
Compare
rgmz
force-pushed
the
feat/update-azurestorage
branch
3 times, most recently
from
d11e6af to
fcb4e31
Compare
rgmz
force-pushed
the
feat/update-azurestorage
branch
from
fcb4e31 to
7908e8d
Compare
ahrav
approved these changes
Nov 20, 2024
rgmz
force-pushed
the
feat/update-azurestorage
branch
from
7908e8d to
33669f5
Compare
rgmz
force-pushed
the
feat/update-azurestorage
branch
from
33669f5 to
794dc14
Compare
|
@ahrav Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR tightens up the regex forAccountName+AccountKeyand fixes a potential runtime panic when constructing the request.This PR expands the the Azure storage detector to find many common configurations, not just connection strings. It also adds a bunch of unit tests.
Checklist:
make test-community)?make lintthis requires golangci-lint)?