Skip to content

Fix: missing fields in response #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Fix: missing fields in response #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8232ade
Include 'meta' fields only if it exists in API response
Aman-Aalam Sep 6, 2022
dd565b2
Updated semver info
Aman-Aalam Sep 6, 2022
cc4418b
added inline comment describing the change
Aman-Aalam Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/PaymentRails/ResourceCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,10 @@ class ResourceCollection implements Iterator
*/
public function __construct($response, $items, $pager)
{
$this->_page = $response["meta"]["page"];
// Add "meta" fields only when they exist in JSON response
$this->_page = isset($response["meta"]) ? $response["meta"]["page"] : null;
Copy link

@suitedjimster suitedjimster Sep 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which PHP version are we using?
if php7+, we can use null coalescing.$response["meta"]["page"] ?? null

$this->_items = $items;
$this->_records = $response["meta"]["records"];
$this->_records = isset($response["meta"]) ? $response["meta"]["records"] : null;
$this->_pager = $pager;
$this->_index = 0;
if (isset($response["meta"]["pages"])) {
Expand Down
4 changes: 2 additions & 2 deletions lib/PaymentRails/Version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ class Version
* class constants
*/
const MAJOR = 2;
const MINOR = 2;
const TINY = 0;
const MINOR = 1;
const TINY = 4;

/**
* @ignore
Expand Down