Fix: missing fields in response #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aman-Aalam
requested review from
suitedjimster
and removed request for
barnett
Yongyiw
reviewed
Sep 8, 2022
Yongyiw
approved these changes
Sep 8, 2022
| { | ||
| $this->_page = $response["meta"]["page"]; | ||
| // Add "meta" fields only when they exist in JSON response | ||
| $this->_page = isset($response["meta"]) ? $response["meta"]["page"] : null; |
There was a problem hiding this comment.
which PHP version are we using?
if php7+, we can use null coalescing.$response["meta"]["page"] ?? null
suitedjimster
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
This PR checks if the JSON response contains "meta" fields before adding them to response object, to prevent from PHP compilers from generating error messages.
Checklist
If you have questions, create a GitHub Issue in this repository.