Skip to content

reset_du! to set_zero! #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ranocha merged 7 commits into from
Jan 19, 2026
Merged

reset_du! to set_zero! #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
67d007a
`reset_du!` to `set_zero!`
DanielDoehring Nov 30, 2025
015efdd
Merge branch 'main' into set_zero
andrewwinters5000 Dec 2, 2025
1f8b14c
Merge branch 'main' into set_zero
DanielDoehring Jan 19, 2026
7dae8de
require v0.14 of Trixi.jl
ranocha Jan 19, 2026
d134532
update project toml
DanielDoehring Jan 19, 2026
f6ebfc6
docs toml
DanielDoehring Jan 19, 2026
0afd4c6
adapt subcell test value
ranocha Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ Printf = "1"
Roots = "2.1.6"
Static = "1.1.1"
StaticArrays = "1.9"
Trixi = "0.13.9"
Trixi = "0.14"
julia = "1.10"
2 changes: 1 addition & 1 deletion docs/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ HOHQMesh = "0.2"
Literate = "2.20"
OrdinaryDiffEqLowStorageRK = "1.3"
OrdinaryDiffEqSSPRK = "1.2"
Trixi = "0.13"
Trixi = "0.14"
Trixi2Vtk = "0.3.16"
TrixiBottomTopography = "0.1"
3 changes: 1 addition & 2 deletions src/solvers/subcell_limiters.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ function (limiter::Trixi.SubcellLimiterIDP)(u::AbstractArray{<:Any, 4},
t, dt;
kwargs...)
@unpack alpha = limiter.cache.subcell_limiter_coefficients
# TODO: Do not abuse `reset_du!` but maybe implement a generic `set_zero!`
Trixi.@trixi_timeit Trixi.timer() "reset alpha" Trixi.reset_du!(alpha, dg, semi.cache)
Trixi.@trixi_timeit Trixi.timer() "reset alpha" Trixi.set_zero!(alpha, dg, semi.cache)

if limiter.local_twosided
Trixi.@trixi_timeit Trixi.timer() "local twosided" Trixi.idp_local_twosided!(alpha,
Expand Down
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ OrdinaryDiffEqSSPRK = "1.2"
Printf = "1"
Roots = "2.1.6"
Test = "1"
Trixi = "0.13.9"
Trixi = "0.14"
TrixiBottomTopography = "0.1"
TrixiTest = "0.2.1"
2 changes: 1 addition & 1 deletion test/test_tree_2d.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ end # 2LSWE
],
linf=[
1.438395397135686,
4.715200146867988,
4.718113394812609,
4.715083768860907,
4.440892098500626e-16
],
Expand Down