Skip to content

reset_du! to set_zero!#119

Merged
ranocha merged 7 commits intomainfrom
set_zero
Jan 19, 2026
Merged

reset_du! to set_zero!#119
ranocha merged 7 commits intomainfrom
set_zero

Conversation

@DanielDoehring
Copy link
Copy Markdown
Member

@DanielDoehring DanielDoehring added the breaking Changes existing and/or documented behaviour label Nov 30, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.32%. Comparing base (95108c8) to head (0afd4c6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   99.32%   99.32%           
=======================================
  Files          87       87           
  Lines        4587     4587           
=======================================
  Hits         4556     4556           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ranocha
Copy link
Copy Markdown
Member

ranocha commented Dec 1, 2025

Thanks for preparing this. The change will be included in a breaking release of Trixi.jl. Thus, we have to update the compat bounds here accordingly.

Copy link
Copy Markdown
Member

@andrewwinters5000 andrewwinters5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Once a breaking release of Trixi happens we can update here accordingly.

@DanielDoehring DanielDoehring added upstream and removed breaking Changes existing and/or documented behaviour labels Dec 3, 2025
ranocha
ranocha previously approved these changes Jan 19, 2026
ranocha
ranocha previously approved these changes Jan 19, 2026
@ranocha ranocha enabled auto-merge (squash) January 19, 2026 12:44
@DanielDoehring
Copy link
Copy Markdown
Member Author

sorry, forgot the docs toml 😬

ranocha
ranocha previously approved these changes Jan 19, 2026
@DanielDoehring
Copy link
Copy Markdown
Member Author

Hm, do we need to adjust this again?

@bennibolm

@ranocha ranocha mentioned this pull request Jan 19, 2026
@ranocha
Copy link
Copy Markdown
Member

ranocha commented Jan 19, 2026

It also fails on main, see #125. This could be caused by trixi-framework/Trixi.jl#2644 (merged on January 13, after the last successful CI run of TrixiShallowWater.jl).

@bennibolm
Copy link
Copy Markdown
Contributor

bennibolm commented Jan 19, 2026

It also fails on main, see #125. This could be caused by trixi-framework/Trixi.jl#2644 (merged on January 13, after the last successful CI run of TrixiShallowWater.jl).

Yes, this should be the reason. So, we can adapt the one test result.

@ranocha ranocha disabled auto-merge January 19, 2026 15:54
@ranocha ranocha enabled auto-merge (squash) January 19, 2026 15:54
@ranocha ranocha merged commit 72e762e into main Jan 19, 2026
18 checks passed
@ranocha ranocha deleted the set_zero branch January 19, 2026 16:47
@DanielDoehring
Copy link
Copy Markdown
Member Author

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants