Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 87 87
Lines 4587 4587
=======================================
Hits 4556 4556
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for preparing this. The change will be included in a breaking release of Trixi.jl. Thus, we have to update the compat bounds here accordingly. |
andrewwinters5000
left a comment
There was a problem hiding this comment.
Thanks! Once a breaking release of Trixi happens we can update here accordingly.
|
sorry, forgot the docs toml 😬 |
|
Hm, do we need to adjust this again? TrixiShallowWater.jl/test/test_tree_2d.jl Line 875 in 95108c8 |
|
It also fails on |
Yes, this should be the reason. So, we can adapt the one test result. |
|
Thanks guys! |
See trixi-framework/Trixi.jl#2670