Skip to content

Qualify access in docstring of non-exported calc_mean_convergence#2837

Merged
JoshuaLampert merged 4 commits intomainfrom
docsting-calc_mean_convergence
Mar 2, 2026
Merged

Qualify access in docstring of non-exported calc_mean_convergence#2837
JoshuaLampert merged 4 commits intomainfrom
docsting-calc_mean_convergence

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

@JoshuaLampert JoshuaLampert commented Feb 28, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 28, 2026

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.13%. Comparing base (0dedef7) to head (f11a13b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2837   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         596      596           
  Lines       45998    45998           
=======================================
  Hits        44676    44676           
  Misses       1322     1322
Flag Coverage Δ
unittests 97.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ranocha
ranocha approved these changes Feb 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ranocha ranocha added the documentation Improvements or additions to documentation label Mar 1, 2026
@JoshuaLampert JoshuaLampert enabled auto-merge (squash) March 2, 2026 17:09
@JoshuaLampert JoshuaLampert merged commit 6fd4974 into main Mar 2, 2026
40 checks passed
@JoshuaLampert JoshuaLampert deleted the docsting-calc_mean_convergence branch March 2, 2026 18:52
bennibolm added a commit to bennibolm/Trixi.jl that referenced this pull request Mar 30, 2026
@bennibolm @ranocha
@DanielDoehring @dependabot @JoshuaLampert @SimonCan @github-actions @sloede @amrueda @ShahuK283 @jlchan @claude @TJP-Karpowski @benegee @vchuravy @lchristm @vivimie @tristanmontoya
Merge main branch (#146)
f9b17d0 
* Avoid repeated global memory operations in `prolong2interfaces!` for Gauss nodes (trixi-framework#2830)

* prolong2interfaces! 1D

* 2D

* Apply suggestions from code review

---------

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Remove unused tols in examples, Update test vals due to `OrdinaryDiffEqCore3.10` (trixi-framework#2838)

* Remove unused tols

* Update test vals

* remote vals

* Bump the all-github-actions group with 3 updates (trixi-framework#2840)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>

* Gauss-Legendre: Boundary Coordinates for 1D `TreeMesh` (trixi-framework#2827)

* Improve `DGSEM` constructors for different bases

* try

* Update src/solvers/dgsem/dgsem.jl

* try

* fix

* try

* Update src/solvers/dgsem/dgsem.jl

* add aparam

* rev

* fmt

* order

* start

* views

* performance opts, add orientation

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>

* qualify access in docstring (trixi-framework#2837)

* Gauss-Legendre DGSEM Solver: Boundary Nodes for 2D `TreeMesh` (trixi-framework#2841)

* start

* more tests

* rename

* fmt

* 3d add

* Gauss-Legendre DGSEM Solver: 1D Parabolic `TreeMesh` (trixi-framework#2842)

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Add 3d local limiting for conservative variables (trixi-framework#2763)

* Add local limiting for conservative variables (3d)

* Add PR number

* Add comment

* Adapt news.md

---------

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>

* Gauss-Legendre DGSEM: 1D Parabolic Convergence Test (trixi-framework#2843)

* Gauss-Legendre DGSEM: 1D Parabolic Non-Periodic Convergence Test

* gl

* Apply suggestions from code review

* Use julia-downgrade-compat@v2 (trixi-framework#2507)

* use julia-downgrade-compat@v2

* bump compat of DiffEqBase.jl to 6.155.4

* bump compat of Reexport.jl v1.2.2

* try mode: all

* put mode at correct location

* set mode to deps

* use same compat for Reexport.jl as before

* forcedeps, julia_version, force_latest_compatible_version

* remove ignore in dependabot

* bump compats as suggested by Resolver.jl

* use default julia_version

* bump StaticArrays.jl to v1.9.8

* manually run tests

* try to cd into test/ first

* path ..

* add comment

* do not cd into test/

* use at__DIR__

* test if error is specific to threaded tests

* try with Pkg.test and allow_reresolve = false

* drop support for HDF5.jl v0.16

HDF5.jl <v0.17 needs a build step, which can be annoying

* don't use Pkg.test

* pass TRIXI_TEST as environment variable

* downgrade TRIXI_TEST

* add misssing if

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Restructure resizing process of subcell limiting containers (trixi-framework#2836)

* Restructure resizing

* Reset antidiffusive fluxes at start

* Move reset from `resize!` to `reinit_...`

* Add `return`s

* Remove not-needed functions

---------

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Sc/p4est view coupled (trixi-framework#2366)

* Removed another redundant foreach_enumerate funciton definition.

* Removed further redundant definitions.

* Removed unused ncells definition.

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Added integer to string conversion for sving mesh files for coupled simulations.

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Correcte comment fo rglobal cell id converion funciton when input is an array.

* Error arrays for coupled simulations are now pre-allocated.

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Added comment on p4est coupled boundary conditions and that they only work on CArtesian meshes at the moment.

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Change parent mesh boundary condition to trigger more code for the test.

* Corrected argument for P4estMesh.

* Fixed issue with AnalysisCallbackCoupled.

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update examples/p4est_2d_dgsem/elixir_advection_coupled.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Removed code for structured meshes.

* Addedcomments on the mesh views
Added ncells function for vtk conversion.

* Added ncelss for p4est mesh views.

* Added comment about the boundary conditions.

* Added comment about boundary u-array.

* Corrected calculation of linf_error for p4est coupled systems.

* Update examples/p4est_2d_dgsem/elixir_advection_coupled.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Added parameter cfl_diffusive to calculate_dt for SemidiscretizationCoupledP4est.

* Removed analysis callback.

* Reinstated analysis callback for coupled p4est simulations.

* First steps for coupled analysis callback.

* Added more infrastructure for coupled analysis callback.

* Removed debugging code.

* Added comments about coupled analysis callbacks.

* Removed unused callback functions.

* Removed unused references to u_ode_coupled.

* Removed unused call of 'show' for analysis callback for p4est mesh views.

* Applied autoformatter.

* Update src/callbacks_step/analysis.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update test/test_p4est_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update test/test_p4est_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/callbacks_step/analysis_dg2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/callbacks_step/analysis_dg2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/callbacks_step/analysis_dg2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/callbacks_step/analysis_dg2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/callbacks_step/analysis_dg2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/callbacks_step/analysis_dg2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/callbacks_step/analysis.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/callbacks_step/analysis.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/callbacks_step/analysis_dg2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Removed redundant and conflicting redefinition of the function allocate_coupled_boundary_condition.

* Removed unused code to keep the CI on code coverage quiet.

* Apply suggestions from code review

* Update src/callbacks_step/analysis.jl

* Update src/callbacks_step/analysis_dg2d.jl

* Apply suggestions from code review

* Apply suggestions from code review

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Semantic formatting.

* Added coment explaining the index 2 for the cell interfaces.

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Update src/semidiscretization/semidiscretization_hyperbolic.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Checking now if
have_nonconservative_terms(equations)
for non-conservative fluxes.

* Added comments about finding boundary indices and exceeding the domain.

* Added comment about distribution of partial solution vectors onto globals.

* Added comments to boundary updates.

* Improved formatting.

* Update src/solvers/dgsem_tree/dg_2d.jl

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Update src/solvers/dgsem_tree/dg_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Removed offending SemidiscretizationCoupled and corrected usage
of have_nonconservative_terms.

* Removed unused code to keep the code overage quiet.

* Reintroduced calc_boundary_flux_by_type! functions for type stability.
Codecov will complain that these functions are not covered.
But tests fail without it.

* Remove unused code when saving p4est mesh view files.

* Apply suggestions from code review

* Removed redundant test on p4est mesh views.

* Added @threaded to loop.
Using ndims(mesh) instead of hardcoded dimension.

* Corrected syntax error.

* Fixed error with mesh reference.

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Moved the definition of calc_boundary_flux_by_type into
solvers/dgsem_p4est/dg_2d.jl.

* Removed case for have_nonconservative_terms(equations) == true,
as it is not needed at this stage.

* Moved rhs! for mesh::P4estMeshView{2} to the dgsem_p4est directory.

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>

* Removed elixir_advection_meshview.jl, as it was made obsolete
with the latest changes in the p4est mesh view coupling.

* Update src/solvers/dgsem_p4est/dg_2d.jl

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>

* Mark p4est 2d memory test for elixir_advection_coupled.jl
as broken.

* ADded comment about rhs! for coupled p4est meshes in 2d.

* Update src/solvers/dgsem_p4est/dg_2d.jl

* Moved the rhs! meant for coupled p4est meshes.

* Added comment on the use of

function rhs!(du_ode, u_ode, u_global, semis,
              semi::SemidiscretizationHyperbolic, t)

* Added comment for

 function prolong2boundaries!(cache, u, u_global, semis,
                              mesh::P4estMeshView{2},
                              equations, surface_integral, dg::DG)

* Added comments on why we need duplicate looking function definitions
with u_global as argument.

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Added comments on how we construct boundaries.name in
coupled p4est mesh view simulations.

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Corrected Array type.

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Added comment about node_indices_to_name translations for 2d, rather than 3d.

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Replaced 'id' by 'ids' in global_element_id_to_local.

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Reverted to previous version.

* Added time step in output files.

* Applyed auto formatter.

* Revert "Added comments on why we need duplicate looking function definitions"

This reverts commit b778fac.

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/solvers/dgsem_p4est/dg_2d.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Cleaned up definition of boundary conditions.

* Added P4estMeshView to digest_boundary_conditions.

* Renamed 'element' to 'cell'.

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update examples/p4est_2d_dgsem/elixir_advection_coupled.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Changed hard coded dimension 2 in n_nodes^2 to n_nodes^ndims(mesh.parent).

* Update src/semidiscretization/semidiscretization_coupled_p4est.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fixed mesh name for the mesh loading test.

* Update src/meshes/p4est_mesh_view.jl

* Update src/meshes/p4est_mesh_view.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Reinserted comment about index_to_start_step_2d.

* Updated doc string for struct BoundaryConditionCoupledP4est.

* Added comment on the parent mesh.

* Added comments about p4est mesh view coupled implementation.

Moved rhs! for local system next to the rhs! for the coupled system.

* To be more consistent we renamed 'global' to 'parent' where we refer
to data partaining the parent p4est mesh.

* Moved functions related to p4est mesh views into
semidiscretization_coupled_p4est.jl.

Rnamed 'local' to 'view'.

* Added comments on how we compute extract_neighbor_ids_parent.

* Added comments on how we find the cell_index_parent in
BoundaryConditionCoupledP4est.

* Fixed typo.

* Fixed typo.

* Removed doubly defined functions calc_boundary_flux_by_type! and calc_boundary_flux!.

* Removed double function definition of function calc_boundary_flux_by_type!.

* Removed option to generate mesh files with different file names for timestep > 0.

---------

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* set version to v0.15.7

* set development version to v0.15.8-DEV

* Gauss-Legendre DGSEM Solver: 2D `TreeMesh` Parabolic (trixi-framework#2845)

* Start

* refactor

* tests

* Update test/test_parabolic_2d.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* test bnds y

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* `flux_ruedaramirez_etal` normal direction (trixi-framework#2446)

* Implemented fluxes using normal_direction.

* Added example using IdealGlmMhdMultiIonEquations2D equations on a structured mesh.

* Corrected projections for numerical fluxes using normal_direction.

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Compute normal component of velocites to save computaional time.

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Applied the autoformatter.

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Corrections in flux_nonconservative_ruedaramirez_etal for general directions.

* Change the norma_Direction to:
normal_direction::SVector{2,Float64}

* Corrected real type to be more generic.

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Applied autoformatter.

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Applied atoformatter.

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Corrected various typos in the calculation of the fluxes
for IdealGlmMhdMultiIonEquations2D and normal_direction::SVector{2, T}.

* Removed commented out code.

* Added multi ion test for structured mesh.

* Added unit test for IdealGlmMhdMultiIonEquations2D fluxes.

* Added vector normalization.

* Corrected unit test.

* Added test for structured elixir_mhdmultiion_ec.jl and FluxLaxFriedrichs flux.

* Update test/test_unit.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Removed commented out code.

* Optimized calculation of terms involving B.n_avg.

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Added missing definition of boundary conditions.

* Added convergence test as initial condition.

* Added further test for IdealGlmMhdMultiIonEquations2D on structured meshes.

* Changed normal_direction::SVector{2, T} to normal_direction::AbstractVector
for IdealGlmMhdMultiIonEquations2D.

Added type test for new flux implementations for IdealGlmMhdMultiIonEquations2D.

* Update test/test_type.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update test/test_type.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Removed spurious where {T <: Real} arguments.

* Added convergence elixir for IdealGlmMhdMultiIonEquations2D equations.

* Added 2-species convergence test that is failing (but works on TreeMesh)

* Fixed issues in flux_nonconservative_ruedaramirez_etal

* Spice up convergence test with a curvilinear mapping

* Added test for elixir_mhdmultiion_convergence_twospecies.jl.

* Update test/test_structured_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fixed issue with extra memory allocation.

* Updated errors for elixir_mhdmultiion_ec.jl.

* Updated errors for elixir_mhdmultiion_ec.jl test.

* Removed unused initial_condition_convergence_test for IdealGlmMhdMultiIonEquations2D.

* Removed redundant line from flux calculations.

* Changed rho_e to rho_e_total.

* Added test for max_abs and IdealGlmMhdMultiIonEquations2D
on structured meshes and different normal directions.

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Applied code formatting.

* Update src/equations/ideal_glm_mhd_multiion_2d.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>

* Add initial support for subcell limiting with 3D TreeMesh (trixi-framework#2846)

* Add initial support for 3d TreeMesh

* Update NEWS.md

* Split `for` loops over nodes and variables

---------

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Add 3d support for nonperiodic simulations with subcell limiting (trixi-framework#2844)

* Add `calc_bounds_two/onesided_boundary`

* Update NEWS.md

* Move `get_boundary_outer_state()`

* Refactor `StructuredMesh` (trixi-framework#2831)

* Refactor `StructuredMesh`: Interface Values

* project

* rev

* rev

* adjust

* comment

* typo

* revert partwise

* alias

* fix

* rev

* tighten tols

* Update src/semidiscretization/semidiscretization_coupled.jl

* Update src/semidiscretization/semidiscretization_coupled.jl

* Update src/solvers/dgsem_structured/dg.jl

* Update src/solvers/dgsem_structured/dg.jl

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Switch file hosting from Sciebo to Zenodo (trixi-framework#2851)

* switch

* fmt

* Add PlotData2D regression tests (Fixes trixi-framework#2335) (trixi-framework#2765)

* Add PlotData2D regression tests for TreeMesh, StructuredMesh, and P4estMesh

* Apply suggestions from code review

* Fix PlotData2D tests: handle structured/p4est data types and force exact IC

* Revert whitespace changes on existing tests

* Fix regression tests: Use standard constant IC and relax TreeMesh tolerance

* Format test_visualization.jl to resolve CI styling checks

* Format code according to official Trixi style guide (v1.0.60)

* Update PlotData2D tests: implement dynamic ref_prim checks and manual mesh setup

* Remove atol from constant IC tests as suggested

* Apply suggestion from @ranocha

---------

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Adaptive Volume Integral for `DGMulti`: WF & FD, `Polynomial()` & `Affine` (trixi-framework#2850)

* ex

* ana

* fd

* types

* use volume_integral_kernel

* revisit analysis routines

* clean up

* compute du after WF VI

* get Polynomial with AVI to work

* rm SBP

* paper version

* generalize

* refactor

* restrict

* comments

* shorten

* test

* test

* restrict

* Update src/callbacks_step/analysis_dgmulti.jl

Co-authored-by: Jesse Chan <1156048+jlchan@users.noreply.github.com>

* shorten

* Update src/solvers/dgmulti/volume_integral_adaptive.jl

* restrict

* Update src/callbacks_step/analysis_dgmulti.jl

* Update src/callbacks_step/analysis_dgmulti.jl

* Apply suggestions from code review

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Jesse Chan <1156048+jlchan@users.noreply.github.com>

* Add local subcell limiting for `TreeMesh{3}` (trixi-framework#2848)

* Add local limiting for `TreeMesh{3}`

* Adapt test numbers

* Clearify variable names

---------

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* set version to v0.15.8

* set development version to v0.15.9-DEV

* Update Jesse Chan's affiliation to UT Austin (trixi-framework#2860)

* Relocate functions from `P4estMesh` folder to `TreeMesh` folder (trixi-framework#2859)

* Relocate files from `P4estMesh` folder to `TreeMesh` folder

* Update NEWS.md

* Gauss-Legendre on 1D periodic `StructuredMesh` (trixi-framework#2828)

* Start

* retrict

* test

* add

* fix

* Update src/solvers/dgsem_structured/dg_1d.jl

* Refactor DGMulti to use a shared array container (trixi-framework#2853)

* Refactor DGMulti `create_cache` to use shared array-allocation helper

Introduce `DGMultiCommonArrays` struct and `allocate_common_dgmulti_arrays`
to eliminate duplicated allocation of `u_values`, `u_face_values`,
`flux_face_values`, and `local_values_threaded` across the `DGMultiWeakForm`
and `DGMultiFluxDiffSBP` `create_cache` methods.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Store DGMultiCommonArrays as named field in cache, unpack where needed

Replace splatting of `DGMultiCommonArrays` fields into the cache named
tuple with storing the struct directly as `cache.common_arrays`. Update
all access sites across `dg.jl`, `flux_differencing.jl`,
`flux_differencing_gauss_sbp.jl`, `sbp.jl`, and
`analysis_dgmulti.jl` to unpack from `cache.common_arrays`.

Also applies `DGMultiCommonArrays` consistently to all four `create_cache`
variants (`DGMultiWeakForm`, `DGMultiFluxDiffSBP`, `DGMultiFluxDiff`,
`DGMultiFluxDiffPeriodicFDSBP`).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Fix DGMultiCommonArrays type parameter for mismatched face array types

`u_face_values` in the `DGMultiFluxDiff` cache is a view into
`entropy_projected_u_values`, while `flux_face_values = similar(...)`
allocates a fresh array — these have different concrete types.
Split the single `fType` parameter into separate `ufType` and `ffType`
to accommodate this.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* renaming

* fix unpack

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Add `OrdinaryDiffEqDifferentiation` to test (trixi-framework#2865)

* Add `OrdinaryDiffEqDifferentiation" to test

* compat

* compat bounds

* cp

* cp

* cp

* Gauss-Legendre `DGSEM` Solver: `Structured` 1D: Boundaries (trixi-framework#2864)

* Gauss-Legendre DGSEM Solver: Structured 1D: Boundaries

* fix

* bf

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Add LLM statement to CONTRIBUTING.md (trixi-framework#2863)

* add LLM statemnet

* Update CONTRIBUTING.md

Co-authored-by: Daniel Doehring <doehringd2@gmail.com>

* modify checklist link

* fix

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>

* set version to v0.15.9

* set development version to v0.15.10-DEV

* Revert unintended `adaptive = false` (trixi-framework#2876)

* Convergence Test MHD 3D (Non-Alfwen Wave) (trixi-framework#2875)

* start

* fmt

* Update examples/tree_3d_dgsem/elixir_mhd_convergence.jl

* Apply suggestions from code review

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Update examples/tree_3d_dgsem/elixir_mhd_convergence.jl

* Update examples/tree_3d_dgsem/elixir_mhd_convergence.jl

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Refactor DGMulti by consolidating functionality into `local_flux_differencing!` (trixi-framework#2857)

* Refactoring shock capturing for DGMulti

* formatting

* Refactor local_flux_differencing! to eliminate LazyMatrixLinearCombo

Dense conservative path now uses a per-pair loop with a single flux call
using normal direction n_ij = geometric_matrix * ref_entries, replacing
the dimension-by-dimension LazyMatrixLinearCombo + hadamard_sum! approach.
Sparse non-conservative path replaces LazyMatrixLinearCombo((Q,),(0.5,))
with 0.5 * normal_direction. Removes build_lazy_physical_derivative,
LazyMatrixLinearCombo, and the now-unused hadamard_sum! overloads.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* formatting

* Restore hadamard_sum! overload for NonAffine curved meshes

The per-pair normal-averaging overload for AbstractVector{<:AbstractVector}
was accidentally removed. On NonAffine meshes, get_contravariant_vector
returns an SVector of per-node array views; this overload averages the
normals at nodes i and j before calling the volume flux.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Fix sbp.jl FD-SBP volume integral after hadamard_sum! cleanup

The single-thread branch was calling hadamard_sum! with a plain
SparseMatrixCSC (dg.basis.Drst[dim]), which matched the now-deleted
dense overload. Replace the call with an inlined symmetric sparse loop
identical in structure to the multithreaded branch, using -vals[id] to
recover A[i,j] from the stored A[j,i] (skew-symmetry of periodic D).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Restore upper-triangular comment in hadamard_sum! NonAffine overload

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* move `flux_differencing_kernel!` directly into volume_integral_kernel!

* add alpha=true to allow for accumulation in volume_integral_kernel!

* move `low_order_flux_differencing!` into `volume_integral_kernel!`

* comments

* move hadamard_sum functionality into local_flux_differencing!

* fix tests - add alpha=true to volume_integral_kernel!

* fix

* format

* remove unused import

* comments

* remove some boilerplate

* use du_local instead of fluxdiff_local

* renaming cache variable for consistency

* remove currently unused cache variable

* renaming

* remove <:Number specialization

* expand comment

* Apply suggestions from code review

Co-authored-by: Daniel Doehring <doehringd2@gmail.com>

* Update src/solvers/dgmulti/flux_differencing.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* fix stale comments

* Apply suggestions from code review

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* fix 0.5f0 factor comments

* add type specialization to `adjoint_sparse_data`

* load Adjoint from LinearAlgebra

* importing SparseMatrixCSC as well

* format

* clarify comment

* Apply suggestions from code review

* fix type specialization for adjoint_sparse_data

* fix adjoint_sparse_data dispatch, expand comment

* rename adjoint_sparse_data for consistency

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Refactor Plots.jl integration into native package extension (trixi-framework#2216) (trixi-framework#2861)

* Refactor Plots.jl integration into native package extension (trixi-framework#2216)

* Fix Plots compat bound for downgrade CI check

* Fix method extension syntax by explicitly prefixing Trixi.

* Restore recipes_plots.jl include and apply Trixi formatting

* Final formatting fix and remove Plots warning

* Update ext/TrixiPlotsExt.jl

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>

* Update ext/TrixiPlotsExt.jl

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>

* Trigger CI to fix flaky cache error

* Apply suggestion from @ranocha

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Apply suggestion from @ranocha

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Update ext/TrixiPlotsExt.jl

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Remove orphaned Plots warning comment

---------

Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Fix syntax for VisualizationCallback parameters (trixi-framework#2883)

The example shows a different call signature than the documentation. Corrected the Documentation to match the example again.

* set version to v0.15.10

* set development version to v0.16.0-DEV

* More robust LDG Switch for `P4estMesh` (trixi-framework#2871)

* More robust LDG Switch for `P4estMesh`

* fmt

* tv

* tv

* readme and docstring

* bf

* Update NEWS.md

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Initial GPU support for P4estMesh 2D and 3D using simple KernelAbstractions kernels (trixi-framework#2590)

Many changes with convoluted development history that does not need to be stored here

---------

Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Co-authored-by: Lars Christmann <account-github@l12n.eu>
Co-authored-by: Vivienne Ehlert <201612348+vivimie@users.noreply.github.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <mail@ranocha.de>

* Rename "viscous" to "parabolic" in general non-fluids settings (trixi-framework#2868)

* rename viscous to parabolic in non-fluid contexts

* rename files

* rename advective/diffusive cfl to hyperbolic/parabolic

* revert NEWS.md

* add change to NEWS.md

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply suggestion from code review

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>

* Apply formatter suggestion

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Apply formatting changes

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Apply formatting changes

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Apply formatting changes

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>

* Update NEWS.md

* fix merge

---------

Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Hendrik Ranocha <mail@ranocha.de>

* set version to v0.16.0

* set development version to v0.16.1-DEV

* CompatHelper: bump compat for Trixi to 0.16 for package benchmark, (keep existing compat) (trixi-framework#2897)

Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>

* Add synchronization statements to ensure timer output correctness on the GPU (trixi-framework#2892)

* Add synchronization statements to ensure timer output correctness on the GPU

* use trixi_timit macro with a backend

* don't commit piracy

* Update src/Trixi.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fixup! Add synchronization statements to ensure timer output correctness on the GPU

Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>

* only synchronize when timers are enabled

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>

* reorder dependency loading in elixi_advection_diffusion_implicit_sparse_jacobian (trixi-framework#2900)

* Merge `main`

* Fix subcell specific stuff

* Fix

* Fix

* Fix

---------

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Co-authored-by: Daniel Doehring <daniel.doehring@rwth-aachen.de>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Lampert <51029046+JoshuaLampert@users.noreply.github.com>
Co-authored-by: Simon Candelaresi <10759273+SimonCan@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
Co-authored-by: Hendrik Ranocha <mail@ranocha.de>
Co-authored-by: Andrés Rueda-Ramírez <aruedara@uni-koeln.de>
Co-authored-by: ShahuK283 <shahukarale283@gmail.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Jesse Chan <1156048+jlchan@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: TJP-Karpowski <49682045+TJP-Karpowski@users.noreply.github.com>
Co-authored-by: Benedict <135045760+benegee@users.noreply.github.com>
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Co-authored-by: Lars Christmann <account-github@l12n.eu>
Co-authored-by: Vivienne Ehlert <201612348+vivimie@users.noreply.github.com>
Co-authored-by: Tristan Montoya <montoya.tristan@gmail.com>
Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranocha ranocha ranocha approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoshuaLampert @ranocha