Skip to content

Return all eocs in convergence_test#285

Merged
JoshuaLampert merged 4 commits intomainfrom
return-all-eocs-convergence_test
Feb 28, 2026
Merged

Return all eocs in convergence_test#285
JoshuaLampert merged 4 commits intomainfrom
return-all-eocs-convergence_test

Conversation

@JoshuaLampert
Copy link
Copy Markdown
Member

Closes #284.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 26, 2026

Benchmark Results (Julia v1.10)

Time benchmarks
main a16f354... main / a16f354...
bbm_1d/bbm_1d_basic.jl - rhs!: 13.7 ± 1.1 μs 12.9 ± 0.39 μs 1.07 ± 0.093
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.486 ± 0.29 ms 0.486 ± 0.0088 ms 0.999 ± 0.59
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0747 ± 0.00041 ms 0.0746 ± 0.00022 ms 1 ± 0.0063
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0317 ± 0.0028 ms 0.0321 ± 0.00068 ms 0.99 ± 0.09
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 25.6 ± 2.9 μs 25.2 ± 2.6 μs 1.01 ± 0.15
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0449 ± 0.0011 ms 0.045 ± 0.00086 ms 0.997 ± 0.032
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 3.91 ± 0.031 μs 3.9 ± 0.03 μs 1 ± 0.011
kdv_1d/kdv_1d_basic.jl - rhs!: 1.31 ± 0.011 μs 1.3 ± 0.019 μs 1.01 ± 0.017
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.38 ± 0.11 μs 1.3 ± 0.029 μs 1.06 ± 0.088
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.178 ± 0.0074 ms 0.18 ± 0.0086 ms 0.991 ± 0.063
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.132 ± 0.0028 ms 0.132 ± 0.0032 ms 1 ± 0.033
time_to_load 3.07 ± 0.035 s 3.05 ± 0.0043 s 1 ± 0.012
Memory benchmarks
main a16f354... main / a16f354...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just have a minor suggestion.

Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Copy link
Copy Markdown
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaLampert JoshuaLampert enabled auto-merge (squash) February 27, 2026 20:47
@JoshuaLampert
Copy link
Copy Markdown
Member Author

JoshuaLampert commented Feb 27, 2026

Some SciML failures again...🙄
Edit: This is SciML/SciMLBase.jl#1259.

@ChrisRackauckas
Copy link
Copy Markdown

Sorry the type piracy was fixed. We should be in a pretty good spot now, code movement is hopefully done. Let us know if there are any major invalidations that you find though, as that is really the impetus for most of the required clean up.

@JoshuaLampert JoshuaLampert merged commit 7f77f95 into main Feb 28, 2026
18 of 19 checks passed
@JoshuaLampert JoshuaLampert deleted the return-all-eocs-convergence_test branch February 28, 2026 07:45
@JoshuaLampert
Copy link
Copy Markdown
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return full eocs in convergence_test

4 participants