-
Notifications
You must be signed in to change notification settings - Fork 141
Refactor: Shorten package extension names (Fixes #2543) #2747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor: Shorten package extension names (Fixes #2543) #2747
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
|
Thanks for the PR! Please note #2543 (comment), i.e., currently the docs of Pkg.jl does not hold what it promises. I already fixed that in julia, see JuliaLang/julia#60456 and it will be backported to julia v1.10, v1.12, and v1.13. It will probably be available in julia |
Did I miss something? Is 1.10.11 already underway? |
|
There is JuliaLang/julia#58889 and the PR was not yet added to that list (in contrast to the corresponding backport PRs for v1.12.5 and v1.13-beta2). So I thought, it will not be included in v1.10.11, but needs to wait for the following patch release. But we'll see. Edit: Now it looks like it will be included in v1.10.11. |
ranocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As described in the discussion, we should not do this right now (and even when Pkg's printing behavior is changed, I am not sure we really should do this change).
|
Thanks for the explanation, @JoshuaLampert and @ranocha! I understand that this depends on the upstream Pkg.jl fix landing in future Julia releases. I am happy to leave this PR open until those versions are released, or I can close it if you prefer to wait until later to revisit this. Just let me know what works best for the workflow! |
|
I think it's fine to keep it open for now. |
|
@ranocha @JoshuaLampert As discussed in issue #2335, I have added the regression tests for PlotData2D covering TreeMesh, StructuredMesh, and P4estMesh. I pushed them to this branch so we can check the CI results. Since this is unrelated to the extension renaming, let me know if you would prefer I open a fresh PR for just the regression tests! |
|
Thanks! Yes, please move this to another branch from which you open a new PR. We can check CI in that new PR. |
|
Thanks for the guidance! I have moved the regression tests to a new PR as requested: #2765 |
4ca8157 to
4683378
Compare
Refactors package extension names by removing the redundant 'Trixi' prefix, aligning with Pkg.jl documentation recommendations.
Changes:
ext/(e.g.,TrixiSparseConnectivityTracerExt.jl->SparseConnectivityTracerExt.jl).Project.tomlextension keys to match the new filenames.Trixiprefix.Testing:
using Trixi.