-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Print full_name after precompiling extension
#60456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print full_name after precompiling extension
#60456
Conversation
|
This looks correct and all the places you highlighted also. If you can add them I'll approve. Thanks! |
|
Great, I'll add them in a minute. Thanks for the quick reply! |
|
I added the first two. For the third one within |
|
I think so, or pass in the result of |
I did that in 7c59dfb. |
|
Thanks, this really bothered me a few times lately. It would be great if this could get backported to 1.12 and 1.13. |
|
Thanks! |
This PR fixes #60047 to print the full package name
ParentPkg → ExtensionNameinstead of only theExtensionNameto match what the docs say:I have looked for more possible locations, which should print the
full_nameand found the possible candidates:julia/base/precompilation.jl
Line 936 in db0ee41
julia/base/precompilation.jl
Line 1329 in db0ee41
julia/base/precompilation.jl
Line 1380 in db0ee41
For these locations, I'm not entirely sure though whether they should print the full name.
Since this is my first PR to julia itself, I would be grateful for any guidance on anything I might have missed.
Fixes #60047